From e4ce3cc5f26dd4f3cf9058add87314eb442414c1 Mon Sep 17 00:00:00 2001 From: jovanak Date: Thu, 19 Apr 2018 12:17:12 -0700 Subject: [PATCH] "Guest" icon should be a default user icon. Needed to call getDefaultUserIcon with UserHandle.USER_NULL. Guest icon should not have individual user coloring. Bug: 77870451 Test: Visual tests on mojave. Change-Id: I164e2dcb78cdd40e899b3005b220be564565f6d2 --- .../statusbar/car/UserGridRecyclerView.java | 25 +++++++++++++------ 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/car/UserGridRecyclerView.java b/packages/SystemUI/src/com/android/systemui/statusbar/car/UserGridRecyclerView.java index dbd1cd482305c..f1e2302ceda24 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/car/UserGridRecyclerView.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/car/UserGridRecyclerView.java @@ -20,7 +20,9 @@ import android.content.Context; import android.content.pm.UserInfo; import android.content.res.ColorStateList; import android.content.res.Resources; +import android.graphics.Bitmap; import android.os.AsyncTask; +import android.os.UserHandle; import android.support.v7.widget.RecyclerView; import android.util.AttributeSet; import android.view.LayoutInflater; @@ -31,6 +33,7 @@ import android.widget.TextView; import androidx.car.widget.PagedListView; +import com.android.internal.util.UserIcons; import com.android.settingslib.users.UserManagerHelper; import com.android.systemui.R; @@ -180,13 +183,7 @@ public class UserGridRecyclerView extends PagedListView implements @Override public void onBindViewHolder(UserAdapterViewHolder holder, int position) { UserRecord userRecord = mUsers.get(position); - if (!userRecord.mIsAddUser) { - holder.mUserAvatarImageView.setImageBitmap(mUserManagerHelper - .getUserIcon(userRecord.mInfo)); - } else { - holder.mUserAvatarImageView.setImageDrawable(mContext - .getDrawable(R.drawable.car_add_circle_round)); - } + holder.mUserAvatarImageView.setImageBitmap(getUserRecordIcon(userRecord)); holder.mUserNameTextView.setText(userRecord.mInfo.name); holder.mView.setOnClickListener(v -> { if (userRecord == null) { @@ -219,6 +216,20 @@ public class UserGridRecyclerView extends PagedListView implements } + private Bitmap getUserRecordIcon(UserRecord userRecord) { + if (userRecord.mIsStartGuestSession) { + return UserIcons.convertToBitmap(UserIcons.getDefaultUserIcon( + mContext.getResources(), UserHandle.USER_NULL, false)); + } + + if (userRecord.mIsAddUser) { + return UserIcons.convertToBitmap(mContext + .getDrawable(R.drawable.car_add_circle_round)); + } + + return mUserManagerHelper.getUserIcon(userRecord.mInfo); + } + private class AddNewUserTask extends AsyncTask { @Override