diff --git a/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/framework/BrowseActivity.kt b/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/framework/BrowseActivity.kt index a8432d60065ab..bccd8aaea842e 100644 --- a/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/framework/BrowseActivity.kt +++ b/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/framework/BrowseActivity.kt @@ -139,9 +139,7 @@ private fun NavControllerWrapperImpl.NavContent(allProvider: Collection - val page = remember(navBackStackEntry.arguments) { - spp.createSettingsPage(navBackStackEntry.arguments) - } + val page = remember { spp.createSettingsPage(navBackStackEntry.arguments) } page.PageWithEvent() } } diff --git a/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/framework/common/SettingsPageProvider.kt b/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/framework/common/SettingsPageProvider.kt index 42e5f7ed6aae5..c5641303a58c7 100644 --- a/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/framework/common/SettingsPageProvider.kt +++ b/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/framework/common/SettingsPageProvider.kt @@ -18,6 +18,7 @@ package com.android.settingslib.spa.framework.common import android.os.Bundle import androidx.compose.runtime.Composable +import androidx.compose.runtime.remember import androidx.navigation.NamedNavArgument import com.android.settingslib.spa.widget.scaffold.RegularScaffold @@ -52,8 +53,10 @@ interface SettingsPageProvider { /** The [Composable] used to render this page. */ @Composable fun Page(arguments: Bundle?) { - RegularScaffold(title = getTitle(arguments)) { - for (entry in buildEntry(arguments)) { + val title = remember { getTitle(arguments) } + val entries = remember { buildEntry(arguments) } + RegularScaffold(title) { + for (entry in entries) { entry.UiLayout() } }