From 11df7e13a8d3f932ee575361b06e18279344c038 Mon Sep 17 00:00:00 2001
From: Yuncheol Heo <ycheo@google.com>
Date: Tue, 5 May 2020 21:00:49 +0000
Subject: [PATCH] Revert "Notify the visibility change to update color views
 without control."

This reverts commit 02d3a8ad07072a2732e9ff53fe57881279eda3cb.

Reason for revert: the original change caused the infinite message loop.
Bug: 155794233

Change-Id: I3d72541cd51cd8b16ce4f44124d486b4615b09da
---
 core/java/android/view/InsetsSourceConsumer.java | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/core/java/android/view/InsetsSourceConsumer.java b/core/java/android/view/InsetsSourceConsumer.java
index 58ec9ec11e56f..2dcfd899adf40 100644
--- a/core/java/android/view/InsetsSourceConsumer.java
+++ b/core/java/android/view/InsetsSourceConsumer.java
@@ -200,15 +200,6 @@ public class InsetsSourceConsumer {
     }
 
     boolean applyLocalVisibilityOverride() {
-        return applyLocalVisibilityOverride(false /* notifyWithoutControl */);
-    }
-
-    /**
-     * @param notifyWithoutControl set it true when the caller wants to notify the visibility
-     *                             changes even if the consumer doesn't have the control.
-     * @return true if it needs to notify the visibility changes to the controller
-     */
-    private boolean applyLocalVisibilityOverride(boolean notifyWithoutControl) {
         InsetsSource source = mState.peekSource(mType);
         final boolean isVisible = source != null && source.isVisible();
         final boolean hasControl = mSourceControl != null;
@@ -220,7 +211,7 @@ public class InsetsSourceConsumer {
 
         // If we don't have control, we are not able to change the visibility.
         if (!hasControl) {
-            return notifyWithoutControl;
+            return false;
         }
         if (isVisible == mRequestedVisible) {
             return false;
@@ -302,9 +293,7 @@ public class InsetsSourceConsumer {
             mRequestedVisible = requestedVisible;
             mIsAnimationPending = false;
         }
-        // We need to notify the visibility changed even if we don't have mSourceControl in order
-        // to update color views.
-        if (applyLocalVisibilityOverride(true  /* notifyWithoutControl */)) {
+        if (applyLocalVisibilityOverride()) {
             mController.notifyVisibilityChanged();
         }
     }