From 60add8ad01b65d3e1eed1ad04f4248c304edc997 Mon Sep 17 00:00:00 2001 From: Etan Cohen Date: Tue, 27 Sep 2016 12:23:51 -0700 Subject: [PATCH] [NAN] Remove builder API using String to translate to byte[] Per API review: String accessor was not needed (duplicate, semantics not accurate, trivial use-case). (cherry-pick of commit c76ccf3e7e673fb21f27ea8e7482021900b113cf) Bug: 31470256 Test: unit tests & integration (sl4a) testing. Change-Id: Id307702627afd8ee579b540d4c2f65359bf9a925 --- .../android/net/wifi/nan/PublishConfig.java | 19 ------------------- .../android/net/wifi/nan/SubscribeConfig.java | 19 ------------------- 2 files changed, 38 deletions(-) diff --git a/wifi/java/android/net/wifi/nan/PublishConfig.java b/wifi/java/android/net/wifi/nan/PublishConfig.java index 91513713daa38..4b67f9ac0ef99 100644 --- a/wifi/java/android/net/wifi/nan/PublishConfig.java +++ b/wifi/java/android/net/wifi/nan/PublishConfig.java @@ -256,25 +256,6 @@ public final class PublishConfig implements Parcelable { return this; } - /** - * Specify service specific information for the publish session - a simple wrapper - * of {@link PublishConfig.Builder#setServiceSpecificInfo(byte[])} - * obtaining the data from a String. - *

- * Optional. Empty by default. - * - * @param serviceSpecificInfoStr The service specific information string - * to be included (as a byte array) in the publish - * information. - * - * @return The builder to facilitate chaining - * {@code builder.setXXX(..).setXXX(..)}. - */ - public Builder setServiceSpecificInfo(@NonNull String serviceSpecificInfoStr) { - mServiceSpecificInfo = serviceSpecificInfoStr.getBytes(); - return this; - } - /** * The match filter for a publish session. Used to determine whether a service * discovery occurred - in addition to relying on the service name. diff --git a/wifi/java/android/net/wifi/nan/SubscribeConfig.java b/wifi/java/android/net/wifi/nan/SubscribeConfig.java index b1dcd8fe49d06..4352fcf6a3cf9 100644 --- a/wifi/java/android/net/wifi/nan/SubscribeConfig.java +++ b/wifi/java/android/net/wifi/nan/SubscribeConfig.java @@ -288,25 +288,6 @@ public final class SubscribeConfig implements Parcelable { return this; } - /** - * Specify service specific information for the subscribe session - a simple wrapper - * of {@link SubscribeConfig.Builder#setServiceSpecificInfo(byte[])} - * obtaining the data from a String. - *

- * Optional. Empty by default. - * - * @param serviceSpecificInfoStr The service specific information string - * to be included (as a byte array) in the subscribe - * information. - * - * @return The builder to facilitate chaining - * {@code builder.setXXX(..).setXXX(..)}. - */ - public Builder setServiceSpecificInfo(@NonNull String serviceSpecificInfoStr) { - mServiceSpecificInfo = serviceSpecificInfoStr.getBytes(); - return this; - } - /** * The match filter for a subscribe session. Used to determine whether a service * discovery occurred - in addition to relying on the service name.