From 6a24de2ab43e915448b86f6bacaba689f8f37642 Mon Sep 17 00:00:00 2001 From: Kweku Adams Date: Wed, 30 Nov 2022 19:46:12 +0000 Subject: [PATCH] Use mocked JobParameters. Use a mock of JobParameters so the test doesn't have to changed or affected when the JobParameters constructor is changed. Bug: 253649458 Test: atest NotificationHistoryJobServiceTest Test: atest ReviewNotificationPermissionsJobServiceTest Change-Id: Ic13c1de9d9de1db8d498c48c004b2a382118a045 --- .../notification/NotificationHistoryJobServiceTest.java | 6 +++--- .../ReviewNotificationPermissionsJobServiceTest.java | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/services/tests/uiservicestests/src/com/android/server/notification/NotificationHistoryJobServiceTest.java b/services/tests/uiservicestests/src/com/android/server/notification/NotificationHistoryJobServiceTest.java index af10b9dba63fe..d758e71c62a20 100644 --- a/services/tests/uiservicestests/src/com/android/server/notification/NotificationHistoryJobServiceTest.java +++ b/services/tests/uiservicestests/src/com/android/server/notification/NotificationHistoryJobServiceTest.java @@ -52,9 +52,9 @@ import java.lang.reflect.Field; @RunWith(AndroidTestingRunner.class) public class NotificationHistoryJobServiceTest extends UiServiceTestCase { private NotificationHistoryJobService mJobService; - private JobParameters mJobParams = new JobParameters(null, - NotificationHistoryJobService.BASE_JOB_ID, null, null, null, - 0, false, false, null, null, null); + + @Mock + private JobParameters mJobParams; @Captor ArgumentCaptor mJobInfoCaptor; diff --git a/services/tests/uiservicestests/src/com/android/server/notification/ReviewNotificationPermissionsJobServiceTest.java b/services/tests/uiservicestests/src/com/android/server/notification/ReviewNotificationPermissionsJobServiceTest.java index 3a6c0eb8fc2af..a83eb00dfa1f6 100644 --- a/services/tests/uiservicestests/src/com/android/server/notification/ReviewNotificationPermissionsJobServiceTest.java +++ b/services/tests/uiservicestests/src/com/android/server/notification/ReviewNotificationPermissionsJobServiceTest.java @@ -44,9 +44,9 @@ import org.mockito.Mock; @RunWith(AndroidTestingRunner.class) public class ReviewNotificationPermissionsJobServiceTest extends UiServiceTestCase { private ReviewNotificationPermissionsJobService mJobService; - private JobParameters mJobParams = new JobParameters(null, - ReviewNotificationPermissionsJobService.JOB_ID, null, null, null, - 0, false, false, null, null, null); + + @Mock + private JobParameters mJobParams; @Captor ArgumentCaptor mJobInfoCaptor;