Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Change to return phone count as 0 if voice, sms, data not supported." into nyc-dev

Browse Source
This commit is contained in:
Amit Mahajan
2016-05-02 21:37:05 +00:00
committed by Android (Google) Code Review
parent c99febc3e3 2c222510f6
commit fc6a3ad85b
1 changed files with 24 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
telephony/java/android/telephony/TelephonyManager.java
View File

@@ -24,6 +24,7 @@ import android.app.ActivityThread;
import android.content.ContentResolver;
import android.content.Context;
import android.content.Intent;
import android.net.ConnectivityManager;
import android.net.Uri;
import android.os.BatteryStats;
import android.os.ResultReceiver;
@@ -183,6 +184,7 @@ public class TelephonyManager {
/**
* Returns the number of phones available.
* Returns 0 if none of voice, sms, data is not supported
* Returns 1 for Single standby mode (Single SIM functionality)
* Returns 2 for Dual standby mode.(Dual SIM functionality)
*/
@@ -190,7 +192,28 @@ public class TelephonyManager {
int phoneCount = 1;
switch (getMultiSimConfiguration()) {
case UNKNOWN:
phoneCount = 1;
// if voice or sms or data is supported, return 1 otherwise 0
if (isVoiceCapable() || isSmsCapable()) {
phoneCount = 1;
} else {
// todo: try to clean this up further by getting rid of the nested conditions
if (mContext == null) {
phoneCount = 1;
} else {
// check for data support
ConnectivityManager cm = (ConnectivityManager)mContext.getSystemService(
Context.CONNECTIVITY_SERVICE);
if (cm == null) {
phoneCount = 1;
} else {
if (cm.isNetworkSupported(ConnectivityManager.TYPE_MOBILE)) {
phoneCount = 1;
} else {
phoneCount = 0;
}
}
}
}
break;
case DSDS:
case DSDA: