From 91b1b1c90b16091ded53e9ea843b0858e21602f1 Mon Sep 17 00:00:00 2001 From: Dianne Hackborn Date: Fri, 3 Aug 2012 14:04:30 -0700 Subject: [PATCH 1/2] Fix issue #6921726: Prime: Cannot make or receive phone calls... [NPE at android.graphics.drawable.Drawable.createFromResourceStream] Change-Id: I223428ffb39e883518aad817227f32851ea18aec --- graphics/java/android/graphics/drawable/Drawable.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/graphics/java/android/graphics/drawable/Drawable.java b/graphics/java/android/graphics/drawable/Drawable.java index 540acfa6a2e0b..4bc5a5a6a38cd 100644 --- a/graphics/java/android/graphics/drawable/Drawable.java +++ b/graphics/java/android/graphics/drawable/Drawable.java @@ -778,7 +778,8 @@ public abstract class Drawable { // to the compatibility density only to have them scaled back up when // drawn to the screen. if (opts == null) opts = new BitmapFactory.Options(); - opts.inScreenDensity = res.getDisplayMetrics().noncompatDensityDpi; + opts.inScreenDensity = res != null + ? res.getDisplayMetrics().noncompatDensityDpi : DisplayMetrics.DENSITY_DEVICE; Bitmap bm = BitmapFactory.decodeResourceStream(res, value, is, pad, opts); if (bm != null) { byte[] np = bm.getNinePatchChunk(); From 740087004d9f4089d273cc493f3687577619bb0b Mon Sep 17 00:00:00 2001 From: Daniel Sandler Date: Mon, 6 Aug 2012 14:31:13 -0400 Subject: [PATCH 2/2] Move lots of layout-port/ resources to layout/ . The framework is no longer letting us skate by without a default (unqualified) for of each resource; in particular, the land/port aspect of the configuration appears to be binding much later than it used to. Bug: 6937365 Change-Id: I6bf72c76e707548168fefa9466dc196ffde33ab3 --- .../status_bar_recent_item.xml | 4 +-- .../status_bar_recent_panel.xml | 0 .../status_bar_search_panel.xml | 0 packages/SystemUI/res/values-port/config.xml | 27 -------------- packages/SystemUI/res/values-port/dimens.xml | 35 ------------------- packages/SystemUI/res/values-port/strings.xml | 20 ----------- .../res/{values-port => values}/arrays.xml | 0 packages/SystemUI/res/values/config.xml | 4 +++ packages/SystemUI/res/values/dimens.xml | 14 ++++++++ 9 files changed, 20 insertions(+), 84 deletions(-) rename packages/SystemUI/res/{layout-port => layout}/status_bar_recent_item.xml (98%) rename packages/SystemUI/res/{layout-port => layout}/status_bar_recent_panel.xml (100%) rename packages/SystemUI/res/{layout-port => layout}/status_bar_search_panel.xml (100%) delete mode 100644 packages/SystemUI/res/values-port/config.xml delete mode 100644 packages/SystemUI/res/values-port/dimens.xml delete mode 100644 packages/SystemUI/res/values-port/strings.xml rename packages/SystemUI/res/{values-port => values}/arrays.xml (100%) diff --git a/packages/SystemUI/res/layout-port/status_bar_recent_item.xml b/packages/SystemUI/res/layout/status_bar_recent_item.xml similarity index 98% rename from packages/SystemUI/res/layout-port/status_bar_recent_item.xml rename to packages/SystemUI/res/layout/status_bar_recent_item.xml index ca72530956cb7..50643abf61b16 100644 --- a/packages/SystemUI/res/layout-port/status_bar_recent_item.xml +++ b/packages/SystemUI/res/layout/status_bar_recent_item.xml @@ -38,7 +38,7 @@ android:fadingEdgeLength="@dimen/status_bar_recents_text_fading_edge_length" android:scrollHorizontally="true" android:layout_alignParentLeft="true" - android:layout_alignTop="@id/app_icon" + android:layout_alignTop="@+id/app_icon" android:paddingTop="2dp" android:layout_marginLeft="@dimen/status_bar_recents_app_label_left_margin" android:singleLine="true" @@ -71,7 +71,7 @@ android:background="@drawable/recents_callout_line" /> - - - - - - - 90 - - diff --git a/packages/SystemUI/res/values-port/dimens.xml b/packages/SystemUI/res/values-port/dimens.xml deleted file mode 100644 index de7b836ce3f9e..0000000000000 --- a/packages/SystemUI/res/values-port/dimens.xml +++ /dev/null @@ -1,35 +0,0 @@ - - - - - - 20dp - - 8dp - - 88dip - - 0dip - - 100dip - - 0dip - - 0dp - 8dp - diff --git a/packages/SystemUI/res/values-port/strings.xml b/packages/SystemUI/res/values-port/strings.xml deleted file mode 100644 index 67364a4cc61d4..0000000000000 --- a/packages/SystemUI/res/values-port/strings.xml +++ /dev/null @@ -1,20 +0,0 @@ - - - - diff --git a/packages/SystemUI/res/values-port/arrays.xml b/packages/SystemUI/res/values/arrays.xml similarity index 100% rename from packages/SystemUI/res/values-port/arrays.xml rename to packages/SystemUI/res/values/arrays.xml diff --git a/packages/SystemUI/res/values/config.xml b/packages/SystemUI/res/values/config.xml index 66add1aacb08e..1cd7904d0ffd7 100644 --- a/packages/SystemUI/res/values/config.xml +++ b/packages/SystemUI/res/values/config.xml @@ -68,5 +68,9 @@ 10 + + + 90 diff --git a/packages/SystemUI/res/values/dimens.xml b/packages/SystemUI/res/values/dimens.xml index 6fc79c59bd5f6..8204e95ef87b8 100644 --- a/packages/SystemUI/res/values/dimens.xml +++ b/packages/SystemUI/res/values/dimens.xml @@ -39,6 +39,20 @@ 10dip 100dip + + 20dp + + 8dp + + 88dip + + 0dip + + 0dip + + 0dp + 8dp + -12dp