Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix mLteSignalStrength range check"

Browse Source
This commit is contained in:
Treehugger Robot
2018-03-10 00:40:19 +00:00
committed by Gerrit Code Review
parent baa37dbbad 32e6d464f1
commit fbf9d61bb2
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
telephony/java/android/telephony/SignalStrength.java
View File

@@ -906,11 +906,8 @@ public class SignalStrength implements Parcelable {
if (rsrpIconLevel != -1) return rsrpIconLevel;
/* Valid values are (0-63, 99) as defined in TS 36.331 */
// TODO the range here is probably supposed to be (0..31, 99). It's unclear if anyone relies
// on the current incorrect range check, so this will be fixed in a future release with more
// soak time
if (mLteSignalStrength > 63) rssiIconLevel = SIGNAL_STRENGTH_NONE_OR_UNKNOWN;
/* Valid values are (0-31, 99) as defined in TS 27.007 8.5 */
if (mLteSignalStrength > 31) rssiIconLevel = SIGNAL_STRENGTH_NONE_OR_UNKNOWN;
else if (mLteSignalStrength >= 12) rssiIconLevel = SIGNAL_STRENGTH_GREAT;
else if (mLteSignalStrength >= 8) rssiIconLevel = SIGNAL_STRENGTH_GOOD;
else if (mLteSignalStrength >= 5) rssiIconLevel = SIGNAL_STRENGTH_MODERATE;