From 693ea60e9e3d2ef476e4f45caac234360d90bdb9 Mon Sep 17 00:00:00 2001 From: Kenny Root Date: Fri, 31 Oct 2014 10:28:04 -0700 Subject: [PATCH] Track change to Conscrypt Change way in which an outside caller can get the preferred SSLContext. (cherry picked from commit 8a970637208207955fb6a719bd82902384b3c743) Bug: 19798387 Bug: 17136008 Change-Id: Ide578664bcb605304322bfddd2e640a63042fa09 --- core/java/android/net/SSLCertificateSocketFactory.java | 2 +- core/java/android/net/http/HttpsConnection.java | 2 +- tests/CoreTests/android/core/SSLSocketTest.java | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/core/java/android/net/SSLCertificateSocketFactory.java b/core/java/android/net/SSLCertificateSocketFactory.java index c15e6e55ab452..6654577f310a0 100644 --- a/core/java/android/net/SSLCertificateSocketFactory.java +++ b/core/java/android/net/SSLCertificateSocketFactory.java @@ -208,7 +208,7 @@ public class SSLCertificateSocketFactory extends SSLSocketFactory { private SSLSocketFactory makeSocketFactory( KeyManager[] keyManagers, TrustManager[] trustManagers) { try { - OpenSSLContextImpl sslContext = new OpenSSLContextImpl(); + OpenSSLContextImpl sslContext = OpenSSLContextImpl.getPreferred(); sslContext.engineInit(keyManagers, trustManagers, null); sslContext.engineGetClientSessionContext().setPersistentCache(mSessionCache); return sslContext.engineGetSocketFactory(); diff --git a/core/java/android/net/http/HttpsConnection.java b/core/java/android/net/http/HttpsConnection.java index 6bf01e241698f..a8674de15ad4d 100644 --- a/core/java/android/net/http/HttpsConnection.java +++ b/core/java/android/net/http/HttpsConnection.java @@ -79,7 +79,7 @@ public class HttpsConnection extends Connection { cache = FileClientSessionCache.usingDirectory(sessionDir); } - OpenSSLContextImpl sslContext = new OpenSSLContextImpl(); + OpenSSLContextImpl sslContext = OpenSSLContextImpl.getPreferred(); // here, trust managers is a single trust-all manager TrustManager[] trustManagers = new TrustManager[] { diff --git a/tests/CoreTests/android/core/SSLSocketTest.java b/tests/CoreTests/android/core/SSLSocketTest.java index b06790bc715d6..65062c2e42f15 100644 --- a/tests/CoreTests/android/core/SSLSocketTest.java +++ b/tests/CoreTests/android/core/SSLSocketTest.java @@ -907,7 +907,7 @@ public class SSLSocketTest extends TestCase { */ public void testClientSessionCaching() throws IOException, KeyManagementException { - OpenSSLContextImpl context = new OpenSSLContextImpl(); + OpenSSLContextImpl context = OpenSSLContextImpl.getPreferred(); // Cache size = 2. FakeClientSessionCache fakeCache = new FakeClientSessionCache(); @@ -1000,7 +1000,7 @@ public class SSLSocketTest extends TestCase { public void testFileBasedClientSessionCache() throws IOException, KeyManagementException { - OpenSSLContextImpl context = new OpenSSLContextImpl(); + OpenSSLContextImpl context = OpenSSLContextImpl.getPreferred(); String tmpDir = System.getProperty("java.io.tmpdir"); if (tmpDir == null) { fail("Please set 'java.io.tmpdir' system property.");