From de16b869308b1d667743bac3deba5d7b2b3c5889 Mon Sep 17 00:00:00 2001 From: Prathmesh Prabhu Date: Fri, 4 Mar 2016 15:22:24 -0800 Subject: [PATCH] SettingsProvider: Add default value for SHOW_IME_WITH_HARD_KEYBOARD. Allow OEMs to override default behaviour wrt. showing IME with a hardware keyboard is connected. Current behaviour remains unchanged. BUG: 27503877 BUG: 27484734 Change-Id: I7ed70b195c3ae98471e413b3eecc5d8fcd3dee26 --- .../SettingsProvider/res/values/defaults.xml | 3 +++ .../providers/settings/SettingsProvider.java | 18 +++++++++++++++++- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/packages/SettingsProvider/res/values/defaults.xml b/packages/SettingsProvider/res/values/defaults.xml index 51d8ca03d4af9..978ca9466ff11 100644 --- a/packages/SettingsProvider/res/values/defaults.xml +++ b/packages/SettingsProvider/res/values/defaults.xml @@ -155,6 +155,9 @@ 500 + + false + 0 diff --git a/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java b/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java index a424d554729bf..0a1dab4ef2fce 100644 --- a/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java +++ b/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java @@ -1936,7 +1936,7 @@ public class SettingsProvider extends ContentProvider { } private final class UpgradeController { - private static final int SETTINGS_VERSION = 124; + private static final int SETTINGS_VERSION = 125; private final int mUserId; @@ -2116,6 +2116,22 @@ public class SettingsProvider extends ContentProvider { currentVersion = 124; } + if (currentVersion == 124) { + // Version 124: allow OEMs to set a default value for whether IME should be + // shown when a physical keyboard is connected. + final SettingsState secureSettings = getSecureSettingsLocked(userId); + Setting currentSetting = secureSettings.getSettingLocked( + Settings.Secure.SHOW_IME_WITH_HARD_KEYBOARD); + if (currentSetting == null) { + secureSettings.insertSettingLocked( + Settings.Secure.SHOW_IME_WITH_HARD_KEYBOARD, + getContext().getResources().getBoolean( + R.bool.def_show_ime_with_hard_keyboard) ? "1" : "0", + SettingsState.SYSTEM_PACKAGE_NAME); + } + currentVersion = 125; + } + // vXXX: Add new settings above this point. // Return the current version.