From fb6ed353a63d9e27642875867927ffd5a738f565 Mon Sep 17 00:00:00 2001 From: Yuichi Araki Date: Thu, 9 Feb 2017 18:47:18 +0900 Subject: [PATCH] Recycle TypedArrays in Fade and TransitionInflater Test: Builds Change-Id: I91e214eafc87850dca6986af2054e5edca46e724 --- core/java/android/transition/Fade.java | 1 + core/java/android/transition/TransitionInflater.java | 2 ++ 2 files changed, 3 insertions(+) diff --git a/core/java/android/transition/Fade.java b/core/java/android/transition/Fade.java index b0de711d0e3bd..38b89dc4193f5 100644 --- a/core/java/android/transition/Fade.java +++ b/core/java/android/transition/Fade.java @@ -103,6 +103,7 @@ public class Fade extends Visibility { TypedArray a = context.obtainStyledAttributes(attrs, R.styleable.Fade); int fadingMode = a.getInt(R.styleable.Fade_fadingMode, getMode()); setMode(fadingMode); + a.recycle(); } @Override diff --git a/core/java/android/transition/TransitionInflater.java b/core/java/android/transition/TransitionInflater.java index 4c5a717647280..0cc981e4151d2 100644 --- a/core/java/android/transition/TransitionInflater.java +++ b/core/java/android/transition/TransitionInflater.java @@ -276,9 +276,11 @@ public class TransitionInflater { transition.addTarget(clazz); } } catch (ClassNotFoundException e) { + a.recycle(); throw new RuntimeException("Could not create " + className, e); } } + a.recycle(); } else { throw new RuntimeException("Unknown scene name: " + parser.getName()); }