From fb4dbb78122ceaeb9ff2bd14fe5f702b077ba44d Mon Sep 17 00:00:00 2001 From: tmfang Date: Tue, 30 Apr 2019 11:52:15 +0800 Subject: [PATCH] Add logging enums for slice converter exceptions - [Refactor] Also remove ACTION_DISPLAY_WHITE_BALANCE_SETTING_CHANGED to Action enum. Test: Rebuild rom Bug: 131449561 Change-Id: I4edfdf275b7858a57cb12a1b4e3c03d2ec37e181 --- core/proto/android/app/settings_enums.proto | 19 ++++++++++++++----- .../metrics_constants/metrics_constants.proto | 9 +++++++++ 2 files changed, 23 insertions(+), 5 deletions(-) diff --git a/core/proto/android/app/settings_enums.proto b/core/proto/android/app/settings_enums.proto index 1160b357a1fbf..36eb4c46faa87 100644 --- a/core/proto/android/app/settings_enums.proto +++ b/core/proto/android/app/settings_enums.proto @@ -666,6 +666,11 @@ enum Action { //ACTION: Log result for each card's eligibility check ACTION_CONTEXTUAL_CARD_ELIGIBILITY = 1686; + // ACTION: Display white balance setting enabled or disabled. + // CATEGORY: SETTINGS + // OS: Q + ACTION_DISPLAY_WHITE_BALANCE_SETTING_CHANGED = 1703; + // ACTION: Share a Wi-Fi network by generating a QR code ACTION_SETTINGS_SHARE_WIFI_QR_CODE = 1710; @@ -674,6 +679,15 @@ enum Action { // ACTION: Share Wi-Fi hotspot by generating a QR code ACTION_SETTINGS_SHARE_WIFI_HOTSPOT_QR_CODE = 1712; + + // ACTION: Settings > Initialize Search bar > Verify Slice > Invalid data + ACTION_VERIFY_SLICE_ERROR_INVALID_DATA = 1725; + + // ACTION: Settings > Initialize Search bar > Verify Slice > Parsing error + ACTION_VERIFY_SLICE_PARSING_ERROR = 1726; + + // ACTION: Settings > Initialize Search bar > Verify Slice > Other exception + ACTION_VERIFY_SLICE_OTHER_EXCEPTION = 1727; } /** @@ -2341,11 +2355,6 @@ enum PageId { // Open: Settings > app > bubble settings > confirmation dialog DIALOG_APP_BUBBLE_SETTINGS = 1702; - // ACTION: Display white balance setting enabled or disabled. - // CATEGORY: SETTINGS - // OS: Q - ACTION_DISPLAY_WHITE_BALANCE_SETTING_CHANGED = 1703; - // OPEN: Settings > Pick SIM dialog DIALOG_SIM_LIST = 1707; diff --git a/proto/src/metrics_constants/metrics_constants.proto b/proto/src/metrics_constants/metrics_constants.proto index e30e166a46b55..5fd14a37f23ce 100644 --- a/proto/src/metrics_constants/metrics_constants.proto +++ b/proto/src/metrics_constants/metrics_constants.proto @@ -7284,6 +7284,15 @@ message MetricsEvent { // type of response could not be determined AUTOFILL_AUGMENTED_RESPONSE = 1724; + // ACTION: Settings > Initialize Search bar > Verify Slice > Invalid data + ACTION_VERIFY_SLICE_ERROR_INVALID_DATA = 1725; + + // ACTION: Settings > Initialize Search bar > Verify Slice > Parsing error + ACTION_VERIFY_SLICE_PARSING_ERROR = 1726; + + // ACTION: Settings > Initialize Search bar > Verify Slice > Other exception + ACTION_VERIFY_SLICE_OTHER_EXCEPTION = 1727; + // ---- Skipping ahead to avoid conflicts between master and release branches. // OPEN: Settings > System > Gestures > Global Actions Panel // CATEGORY: SETTINGS