From d0bfa7d4628538320a8ba7a161460530c8d204bb Mon Sep 17 00:00:00 2001 From: Fiona Campbell Date: Fri, 27 Jan 2023 12:51:45 +0000 Subject: [PATCH] Ignore dwb bias if lux = -1 If ambient lux is -1, ignore the brightness to bias spline, since this is not a valid value that should be considered. Bug: 258765080 Test: atest com.android.server.display Change-Id: Ib2a44ad5fe0490e9e322738de4e63c423b6b0036 --- .../whitebalance/DisplayWhiteBalanceController.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/services/core/java/com/android/server/display/whitebalance/DisplayWhiteBalanceController.java b/services/core/java/com/android/server/display/whitebalance/DisplayWhiteBalanceController.java index 85d5b4f0a1faa..5b772fc917c5f 100644 --- a/services/core/java/com/android/server/display/whitebalance/DisplayWhiteBalanceController.java +++ b/services/core/java/com/android/server/display/whitebalance/DisplayWhiteBalanceController.java @@ -419,16 +419,16 @@ public class DisplayWhiteBalanceController implements float ambientBrightness = mBrightnessFilter.getEstimate(time); mLatestAmbientBrightness = ambientBrightness; - if (ambientColorTemperature != -1.0f && - mLowLightAmbientBrightnessToBiasSpline != null) { + if (ambientColorTemperature != -1.0f && ambientBrightness != -1.0f + && mLowLightAmbientBrightnessToBiasSpline != null) { float bias = mLowLightAmbientBrightnessToBiasSpline.interpolate(ambientBrightness); ambientColorTemperature = bias * ambientColorTemperature + (1.0f - bias) * mLowLightAmbientColorTemperature; mLatestLowLightBias = bias; } - if (ambientColorTemperature != -1.0f && - mHighLightAmbientBrightnessToBiasSpline != null) { + if (ambientColorTemperature != -1.0f && ambientBrightness != -1.0f + && mHighLightAmbientBrightnessToBiasSpline != null) { float bias = mHighLightAmbientBrightnessToBiasSpline.interpolate(ambientBrightness); ambientColorTemperature = (1.0f - bias) * ambientColorTemperature + bias