From b639571a3d2c21ac53e82a4a70e25ae15da833e9 Mon Sep 17 00:00:00 2001 From: James O'Leary Date: Tue, 6 Apr 2021 14:56:24 -0400 Subject: [PATCH] Log ThemeOverlayController debug logs - We had some reports of theme colors changing unexpectedly. - We believe this is likely addressed by avoiding creating different color schemes based on if the user is in dark mode and light mode at the time the scheme is generated. This doesn't work well because the user will eventually exit the current light/dark mode and be stuck with the the 'wrong' colors - Enabling debug logs will let us have more data if the bug reproduces on recent builds, as it will show what triggered generating new colors. - We expect low additional traffic from these logs, as they only occur when new colors are generated, and there are very few events that trigger generating new colors, and those events are relatively rare (ex. on boot, assigning a new wallpaper, after completing work profile setup) Test: none Bug: 183392558 Change-Id: I503d9ec88fdc5f84418197bbde6cead59454e40d --- .../src/com/android/systemui/theme/ThemeOverlayController.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/SystemUI/src/com/android/systemui/theme/ThemeOverlayController.java b/packages/SystemUI/src/com/android/systemui/theme/ThemeOverlayController.java index fc9a35d7d54c6..c9011f439352e 100644 --- a/packages/SystemUI/src/com/android/systemui/theme/ThemeOverlayController.java +++ b/packages/SystemUI/src/com/android/systemui/theme/ThemeOverlayController.java @@ -81,7 +81,7 @@ import javax.inject.Inject; @SysUISingleton public class ThemeOverlayController extends SystemUI implements Dumpable { protected static final String TAG = "ThemeOverlayController"; - private static final boolean DEBUG = Log.isLoggable(TAG, Log.DEBUG); + private static final boolean DEBUG = true; protected static final int NEUTRAL = 0; protected static final int ACCENT = 1;