From f9483f0021785a1b0fa23464a79aeecb1cb3c5f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20G=C3=B6llner?= Date: Mon, 7 Mar 2022 16:46:20 +0100 Subject: [PATCH] Fix test: LockscreenShadeTransitionControllerTest This test is currently failing on foldable targets, as the resource `lockscreen_shade_depth_controller_transition_distance` has the value 0, and therefore the progress is never set on the depthController. Test: Test passes Fixes: 223167765 Change-Id: I543784eed4791c83202bc957978419b9b83f944f --- .../LockscreenShadeTransitionControllerTest.kt | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/LockscreenShadeTransitionControllerTest.kt b/packages/SystemUI/tests/src/com/android/systemui/statusbar/LockscreenShadeTransitionControllerTest.kt index 25a5b900f15a1..067caa98102b3 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/LockscreenShadeTransitionControllerTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/LockscreenShadeTransitionControllerTest.kt @@ -87,6 +87,8 @@ class LockscreenShadeTransitionControllerTest : SysuiTestCase() { row = helper.createRow() context.getOrCreateTestableResources() .addOverride(R.bool.config_use_split_notification_shade, false) + context.getOrCreateTestableResources() + .addOverride(R.dimen.lockscreen_shade_depth_controller_transition_distance, 100) transitionController = LockscreenShadeTransitionController( statusBarStateController = statusbarStateController, logger = logger, @@ -246,6 +248,17 @@ class LockscreenShadeTransitionControllerTest : SysuiTestCase() { verify(depthController).transitionToFullShadeProgress = anyFloat() } + @Test + fun testDragDownAmount_depthDistanceIsZero_doesNotSetProgress() { + context.getOrCreateTestableResources() + .addOverride(R.dimen.lockscreen_shade_depth_controller_transition_distance, 0) + configurationController.notifyConfigurationChanged() + + transitionController.dragDownAmount = 10f + + verify(depthController, never()).transitionToFullShadeProgress + } + @Test fun setDragDownAmount_setsValueOnMediaHierarchyManager() { transitionController.dragDownAmount = 10f