Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Ensure that ScanInfo is cached before callbacks fire" am: af740606e8

Browse Source 
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1864976

Change-Id: Ib30acb95f8dd10f8f78c24c681c7541c9241ec7e
This commit is contained in:
Nathan Harold
2021-10-25 20:31:16 +00:00
committed by Automerger Merge Worker
parent 0a3a353ec0 af740606e8
commit f8caad7478
1 changed files with 18 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
telephony/java/android/telephony/TelephonyScanManager.java
View File

@@ -36,6 +36,7 @@ import com.android.telephony.Rlog;
import java.util.Arrays; import java.util.Arrays;
import java.util.List; import java.util.List;
import java.util.Objects;
import java.util.concurrent.Executor; import java.util.concurrent.Executor;
/** /**
@@ -152,16 +153,9 @@ public final class TelephonyScanManager {
throw new RuntimeException( throw new RuntimeException(
"Failed to find NetworkScanInfo with id " + message.arg2); "Failed to find NetworkScanInfo with id " + message.arg2);
} }
NetworkScanCallback callback = nsi.mCallback;
Executor executor = nsi.mExecutor; final NetworkScanCallback callback = nsi.mCallback;
if (callback == null) { final Executor executor = nsi.mExecutor;
throw new RuntimeException(
"Failed to find NetworkScanCallback with id " + message.arg2);
}
if (executor == null) {
throw new RuntimeException(
"Failed to find Executor with id " + message.arg2);
}
switch (message.what) { switch (message.what) {
case CALLBACK_RESTRICTED_SCAN_RESULTS: case CALLBACK_RESTRICTED_SCAN_RESULTS:
@@ -246,9 +240,17 @@ public final class TelephonyScanManager {
NetworkScanRequest request, Executor executor, NetworkScanCallback callback, NetworkScanRequest request, Executor executor, NetworkScanCallback callback,
String callingPackage, @Nullable String callingFeatureId) { String callingPackage, @Nullable String callingFeatureId) {
try { try {
Objects.requireNonNull(request, "Request was null");
Objects.requireNonNull(callback, "Callback was null");
Objects.requireNonNull(executor, "Executor was null");
final ITelephony telephony = getITelephony(); final ITelephony telephony = getITelephony();
if (telephony == null) return null; if (telephony == null) return null;
// The lock must be taken before calling requestNetworkScan because the resulting
// scanId can be invoked asynchronously on another thread at any time after
// requestNetworkScan invoked, leaving a critical section between that call and adding
// the record to the ScanInfo cache.
synchronized (mScanInfo) {
int scanId = telephony.requestNetworkScan( int scanId = telephony.requestNetworkScan(
subId, request, mMessenger, new Binder(), callingPackage, subId, request, mMessenger, new Binder(), callingPackage,
callingFeatureId); callingFeatureId);
@@ -256,7 +258,6 @@ public final class TelephonyScanManager {
Rlog.e(TAG, "Failed to initiate network scan"); Rlog.e(TAG, "Failed to initiate network scan");
return null; return null;
} }
synchronized (mScanInfo) {
// We link to death whenever a scan is started to ensure that we are linked // We link to death whenever a scan is started to ensure that we are linked
// at the point that phone process death might matter. // at the point that phone process death might matter.
// We never unlink because: // We never unlink because: