Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "PreInitializeNativeBridge only if its Available"

Browse Source
This commit is contained in:
Calin Juravle
2014-10-27 15:16:03 +00:00
committed by Gerrit Code Review
parent ced7ebdb1d 79ec4c15ab
commit f7d24d2443
1 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
core/jni/com_android_internal_os_Zygote.cpp
View File

@@ -416,6 +416,10 @@ static pid_t ForkAndSpecializeCommon(JNIEnv* env, uid_t uid, gid_t gid, jintArra
pid_t pid = fork(); pid_t pid = fork();
if (pid == 0) { if (pid == 0) {
if (!is_system_server && dataDir == NULL) {
ALOGE("Application private dir cannot be null");
RuntimeAbort(env);
}
// The child process. // The child process.
gMallocLeakZygoteChild = 1; gMallocLeakZygoteChild = 1;
@@ -429,13 +433,14 @@ static pid_t ForkAndSpecializeCommon(JNIEnv* env, uid_t uid, gid_t gid, jintArra
DropCapabilitiesBoundingSet(env); DropCapabilitiesBoundingSet(env);
bool need_native_bridge = false; bool use_native_bridge = !is_system_server && (instructionSet != NULL)
if (instructionSet != NULL) { && android::NativeBridgeAvailable();
if (use_native_bridge) {
ScopedUtfChars isa_string(env, instructionSet); ScopedUtfChars isa_string(env, instructionSet);
need_native_bridge = android::NeedsNativeBridge(isa_string.c_str()); use_native_bridge = android::NeedsNativeBridge(isa_string.c_str());
} }
if (!MountEmulatedStorage(uid, mount_external, need_native_bridge)) { if (!MountEmulatedStorage(uid, mount_external, use_native_bridge)) {
ALOGW("Failed to mount emulated storage: %s", strerror(errno)); ALOGW("Failed to mount emulated storage: %s", strerror(errno));
if (errno == ENOTCONN || errno == EROFS) { if (errno == ENOTCONN || errno == EROFS) {
// When device is actively encrypting, we get ENOTCONN here // When device is actively encrypting, we get ENOTCONN here
@@ -453,15 +458,10 @@ static pid_t ForkAndSpecializeCommon(JNIEnv* env, uid_t uid, gid_t gid, jintArra
SetRLimits(env, javaRlimits); SetRLimits(env, javaRlimits);
if (!is_system_server && need_native_bridge) { if (use_native_bridge) {
// Set the environment for the apps running with native bridge. ScopedUtfChars isa_string(env, instructionSet);
ScopedUtfChars isa_string(env, instructionSet); // Known non-null because of need_native_... ScopedUtfChars data_dir(env, dataDir);
if (dataDir == NULL) { android::PreInitializeNativeBridge(data_dir.c_str(), isa_string.c_str());
android::PreInitializeNativeBridge(NULL, isa_string.c_str());
} else {
ScopedUtfChars data_dir(env, dataDir);
android::PreInitializeNativeBridge(data_dir.c_str(), isa_string.c_str());
}
} }
int rc = setresgid(gid, gid, gid); int rc = setresgid(gid, gid, gid);