diff --git a/errorprone/java/com/google/errorprone/bugpatterns/android/BinderIdentityChecker.java b/errorprone/java/com/google/errorprone/bugpatterns/android/BinderIdentityChecker.java index 68477edf97d1f..00cd18ca596a3 100644 --- a/errorprone/java/com/google/errorprone/bugpatterns/android/BinderIdentityChecker.java +++ b/errorprone/java/com/google/errorprone/bugpatterns/android/BinderIdentityChecker.java @@ -16,6 +16,7 @@ package com.google.errorprone.bugpatterns.android; +import static com.google.errorprone.BugPattern.LinkType.NONE; import static com.google.errorprone.BugPattern.SeverityLevel.WARNING; import static com.google.errorprone.matchers.Matchers.contains; import static com.google.errorprone.matchers.Matchers.methodInvocation; @@ -52,6 +53,7 @@ import javax.lang.model.element.Modifier; @BugPattern( name = "AndroidFrameworkBinderIdentity", summary = "Verifies that Binder.clearCallingIdentity() is always restored", + linkType = NONE, severity = WARNING) public final class BinderIdentityChecker extends BugChecker implements MethodInvocationTreeMatcher { private static final Matcher CLEAR_CALL = methodInvocation(staticMethod() diff --git a/errorprone/java/com/google/errorprone/bugpatterns/android/BluetoothPermissionChecker.java b/errorprone/java/com/google/errorprone/bugpatterns/android/BluetoothPermissionChecker.java index 9d1cf87a5f9dc..4bee99e0ffcaf 100644 --- a/errorprone/java/com/google/errorprone/bugpatterns/android/BluetoothPermissionChecker.java +++ b/errorprone/java/com/google/errorprone/bugpatterns/android/BluetoothPermissionChecker.java @@ -16,6 +16,7 @@ package com.google.errorprone.bugpatterns.android; +import static com.google.errorprone.BugPattern.LinkType.NONE; import static com.google.errorprone.BugPattern.SeverityLevel.WARNING; import static com.google.errorprone.bugpatterns.android.RequiresPermissionChecker.simpleNameMatches; import static com.google.errorprone.matchers.Matchers.allOf; @@ -60,6 +61,7 @@ import java.util.regex.Pattern; @BugPattern( name = "AndroidFrameworkBluetoothPermission", summary = "Verifies that all Bluetooth APIs have consistent permissions", + linkType = NONE, severity = WARNING) public final class BluetoothPermissionChecker extends BugChecker implements MethodTreeMatcher { private static final Matcher BLUETOOTH_API = allOf( diff --git a/errorprone/java/com/google/errorprone/bugpatterns/android/ClientSidePermissionCheckChecker.java b/errorprone/java/com/google/errorprone/bugpatterns/android/ClientSidePermissionCheckChecker.java index 8651a1a7fbeba..d27e7a1468666 100644 --- a/errorprone/java/com/google/errorprone/bugpatterns/android/ClientSidePermissionCheckChecker.java +++ b/errorprone/java/com/google/errorprone/bugpatterns/android/ClientSidePermissionCheckChecker.java @@ -16,6 +16,7 @@ package com.google.errorprone.bugpatterns.android; +import static com.google.errorprone.BugPattern.LinkType.NONE; import static com.google.errorprone.BugPattern.SeverityLevel.WARNING; import static com.google.errorprone.matchers.Matchers.anyOf; import static com.google.errorprone.matchers.Matchers.enclosingClass; @@ -42,6 +43,7 @@ import com.sun.source.tree.Tree; @BugPattern( name = "AndroidFrameworkClientSidePermissionCheck", summary = "Verifies that permission checks aren't done in the app's process", + linkType = NONE, severity = WARNING) public final class ClientSidePermissionCheckChecker extends BugChecker implements MethodInvocationTreeMatcher { diff --git a/errorprone/java/com/google/errorprone/bugpatterns/android/CompatChangeChecker.java b/errorprone/java/com/google/errorprone/bugpatterns/android/CompatChangeChecker.java index e759663b5d16e..43abc8bc3e548 100644 --- a/errorprone/java/com/google/errorprone/bugpatterns/android/CompatChangeChecker.java +++ b/errorprone/java/com/google/errorprone/bugpatterns/android/CompatChangeChecker.java @@ -16,6 +16,7 @@ package com.google.errorprone.bugpatterns.android; +import static com.google.errorprone.BugPattern.LinkType.NONE; import static com.google.errorprone.BugPattern.SeverityLevel.WARNING; import static com.google.errorprone.bugpatterns.android.TargetSdkChecker.binaryTreeExact; import static com.google.errorprone.matchers.Matchers.allOf; @@ -51,6 +52,7 @@ import com.sun.source.tree.Tree.Kind; @BugPattern( name = "AndroidFrameworkCompatChange", summary = "Verifies that behavior changes use the modern compatibility framework", + linkType = NONE, severity = WARNING) public final class CompatChangeChecker extends BugChecker implements BinaryTreeMatcher { private static final Matcher VERSION_CODE = diff --git a/errorprone/java/com/google/errorprone/bugpatterns/android/ContextUserIdChecker.java b/errorprone/java/com/google/errorprone/bugpatterns/android/ContextUserIdChecker.java index 3a1bc1eeb9aea..c1a2048fb59dd 100644 --- a/errorprone/java/com/google/errorprone/bugpatterns/android/ContextUserIdChecker.java +++ b/errorprone/java/com/google/errorprone/bugpatterns/android/ContextUserIdChecker.java @@ -16,6 +16,7 @@ package com.google.errorprone.bugpatterns.android; +import static com.google.errorprone.BugPattern.LinkType.NONE; import static com.google.errorprone.BugPattern.SeverityLevel.WARNING; import static com.google.errorprone.bugpatterns.android.UidChecker.getFlavor; import static com.google.errorprone.matchers.Matchers.anyOf; @@ -54,6 +55,7 @@ import java.util.List; @BugPattern( name = "AndroidFrameworkContextUserId", summary = "Verifies that system_server calls use Context.getUserId()", + linkType = NONE, severity = WARNING) public final class ContextUserIdChecker extends BugChecker implements MethodInvocationTreeMatcher { private static final Matcher INSIDE_MANAGER = diff --git a/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientCollectionsChecker.java b/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientCollectionsChecker.java index c4c1ab6482ee5..209dafaaa8fe8 100644 --- a/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientCollectionsChecker.java +++ b/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientCollectionsChecker.java @@ -16,6 +16,7 @@ package com.google.errorprone.bugpatterns.android; +import static com.google.errorprone.BugPattern.LinkType.NONE; import static com.google.errorprone.BugPattern.SeverityLevel.WARNING; import static com.google.errorprone.matchers.Matchers.isSubtypeOf; @@ -43,6 +44,7 @@ import java.util.List; @BugPattern( name = "AndroidFrameworkEfficientCollections", summary = "Verifies efficient collections best-practices", + linkType = NONE, severity = WARNING) public final class EfficientCollectionsChecker extends BugChecker implements NewClassTreeMatcher { private static final Matcher IS_LIST = isSubtypeOf("java.util.List"); diff --git a/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientParcelableChecker.java b/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientParcelableChecker.java index c29a095ecc1be..cae5d8e6846d6 100644 --- a/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientParcelableChecker.java +++ b/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientParcelableChecker.java @@ -16,6 +16,7 @@ package com.google.errorprone.bugpatterns.android; +import static com.google.errorprone.BugPattern.LinkType.NONE; import static com.google.errorprone.BugPattern.SeverityLevel.WARNING; import static com.google.errorprone.matchers.Matchers.allOf; import static com.google.errorprone.matchers.Matchers.enclosingClass; @@ -45,6 +46,7 @@ import com.sun.source.tree.Tree; @BugPattern( name = "AndroidFrameworkEfficientParcelable", summary = "Verifies Parcelable performance best-practices", + linkType = NONE, severity = WARNING) public final class EfficientParcelableChecker extends BugChecker implements MethodInvocationTreeMatcher { diff --git a/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientStringsChecker.java b/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientStringsChecker.java index 3a0fbd33933f9..5c60d779188c8 100644 --- a/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientStringsChecker.java +++ b/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientStringsChecker.java @@ -16,6 +16,7 @@ package com.google.errorprone.bugpatterns.android; +import static com.google.errorprone.BugPattern.LinkType.NONE; import static com.google.errorprone.BugPattern.SeverityLevel.WARNING; import static com.google.errorprone.matchers.Matchers.allOf; import static com.google.errorprone.matchers.Matchers.anyOf; @@ -63,6 +64,7 @@ import javax.lang.model.element.Modifier; @BugPattern( name = "AndroidFrameworkEfficientStrings", summary = "Verifies efficient Strings best-practices", + linkType = NONE, severity = WARNING) public final class EfficientStringsChecker extends BugChecker implements MethodInvocationTreeMatcher, NewClassTreeMatcher, CompoundAssignmentTreeMatcher { diff --git a/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientXmlChecker.java b/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientXmlChecker.java index b5f26e7dc9dd4..8706a68226eff 100644 --- a/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientXmlChecker.java +++ b/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientXmlChecker.java @@ -16,6 +16,7 @@ package com.google.errorprone.bugpatterns.android; +import static com.google.errorprone.BugPattern.LinkType.NONE; import static com.google.errorprone.BugPattern.SeverityLevel.WARNING; import static com.google.errorprone.matchers.Matchers.anyOf; import static com.google.errorprone.matchers.Matchers.instanceMethod; @@ -61,6 +62,7 @@ import javax.lang.model.element.Name; @BugPattern( name = "AndroidFrameworkEfficientXml", summary = "Verifies efficient XML best-practices", + linkType = NONE, severity = WARNING) public final class EfficientXmlChecker extends BugChecker implements MethodInvocationTreeMatcher, NewClassTreeMatcher { diff --git a/errorprone/java/com/google/errorprone/bugpatterns/android/PendingIntentMutabilityChecker.java b/errorprone/java/com/google/errorprone/bugpatterns/android/PendingIntentMutabilityChecker.java index e323a895ee94c..c1e08217a1634 100644 --- a/errorprone/java/com/google/errorprone/bugpatterns/android/PendingIntentMutabilityChecker.java +++ b/errorprone/java/com/google/errorprone/bugpatterns/android/PendingIntentMutabilityChecker.java @@ -16,6 +16,7 @@ package com.google.errorprone.bugpatterns.android; +import static com.google.errorprone.BugPattern.LinkType.NONE; import static com.google.errorprone.BugPattern.SeverityLevel.WARNING; import static com.google.errorprone.matchers.Matchers.anyOf; import static com.google.errorprone.matchers.Matchers.contains; @@ -45,6 +46,7 @@ import java.util.regex.Pattern; @BugPattern( name = "AndroidFrameworkPendingIntentMutability", summary = "Verifies that FLAG_MUTABLE or FLAG_IMMUTABLE is always set", + linkType = NONE, severity = WARNING) public final class PendingIntentMutabilityChecker extends BugChecker implements MethodInvocationTreeMatcher { diff --git a/errorprone/java/com/google/errorprone/bugpatterns/android/RequiresPermissionChecker.java b/errorprone/java/com/google/errorprone/bugpatterns/android/RequiresPermissionChecker.java index d1e4309c365e8..9a41cb46f1941 100644 --- a/errorprone/java/com/google/errorprone/bugpatterns/android/RequiresPermissionChecker.java +++ b/errorprone/java/com/google/errorprone/bugpatterns/android/RequiresPermissionChecker.java @@ -16,6 +16,7 @@ package com.google.errorprone.bugpatterns.android; +import static com.google.errorprone.BugPattern.LinkType.NONE; import static com.google.errorprone.BugPattern.SeverityLevel.WARNING; import static com.google.errorprone.matchers.Matchers.allOf; import static com.google.errorprone.matchers.Matchers.anyOf; @@ -79,6 +80,7 @@ import javax.lang.model.element.Name; @BugPattern( name = "AndroidFrameworkRequiresPermission", summary = "Verifies that @RequiresPermission annotations are consistent across AIDL", + linkType = NONE, severity = WARNING) public final class RequiresPermissionChecker extends BugChecker implements MethodTreeMatcher, MethodInvocationTreeMatcher { diff --git a/errorprone/java/com/google/errorprone/bugpatterns/android/RethrowFromSystemChecker.java b/errorprone/java/com/google/errorprone/bugpatterns/android/RethrowFromSystemChecker.java index 130b256e66226..f8b401b213b82 100644 --- a/errorprone/java/com/google/errorprone/bugpatterns/android/RethrowFromSystemChecker.java +++ b/errorprone/java/com/google/errorprone/bugpatterns/android/RethrowFromSystemChecker.java @@ -16,6 +16,7 @@ package com.google.errorprone.bugpatterns.android; +import static com.google.errorprone.BugPattern.LinkType.NONE; import static com.google.errorprone.BugPattern.SeverityLevel.WARNING; import static com.google.errorprone.matchers.Matchers.allOf; import static com.google.errorprone.matchers.Matchers.contains; @@ -60,6 +61,7 @@ import java.util.List; @BugPattern( name = "AndroidFrameworkRethrowFromSystem", summary = "Verifies that system_server calls use rethrowFromSystemServer()", + linkType = NONE, severity = WARNING) public final class RethrowFromSystemChecker extends BugChecker implements TryTreeMatcher { private static final Matcher INSIDE_MANAGER = diff --git a/errorprone/java/com/google/errorprone/bugpatterns/android/TargetSdkChecker.java b/errorprone/java/com/google/errorprone/bugpatterns/android/TargetSdkChecker.java index 032ae00536b94..5581d9987866c 100644 --- a/errorprone/java/com/google/errorprone/bugpatterns/android/TargetSdkChecker.java +++ b/errorprone/java/com/google/errorprone/bugpatterns/android/TargetSdkChecker.java @@ -16,6 +16,7 @@ package com.google.errorprone.bugpatterns.android; +import static com.google.errorprone.BugPattern.LinkType.NONE; import static com.google.errorprone.BugPattern.SeverityLevel.WARNING; import static com.google.errorprone.matchers.Matchers.allOf; import static com.google.errorprone.matchers.Matchers.anyOf; @@ -59,6 +60,7 @@ import com.sun.source.tree.Tree.Kind; @BugPattern( name = "AndroidFrameworkTargetSdk", summary = "Verifies that all target SDK comparisons are sane", + linkType = NONE, severity = WARNING) public final class TargetSdkChecker extends BugChecker implements BinaryTreeMatcher { private static final Matcher VERSION_CODE = FieldMatchers diff --git a/errorprone/java/com/google/errorprone/bugpatterns/android/UidChecker.java b/errorprone/java/com/google/errorprone/bugpatterns/android/UidChecker.java index a2ee065cd1cc1..a4ad069fdfac1 100644 --- a/errorprone/java/com/google/errorprone/bugpatterns/android/UidChecker.java +++ b/errorprone/java/com/google/errorprone/bugpatterns/android/UidChecker.java @@ -16,6 +16,7 @@ package com.google.errorprone.bugpatterns.android; +import static com.google.errorprone.BugPattern.LinkType.NONE; import static com.google.errorprone.BugPattern.SeverityLevel.WARNING; import com.google.auto.service.AutoService; @@ -46,6 +47,7 @@ import java.util.regex.Pattern; @BugPattern( name = "AndroidFrameworkUid", summary = "Verifies that PID, UID and user ID arguments aren't crossed", + linkType = NONE, severity = WARNING) public final class UidChecker extends BugChecker implements MethodInvocationTreeMatcher, NewClassTreeMatcher {