From ef401300e8a9f819fa7b1c8c20b9800cc24ce489 Mon Sep 17 00:00:00 2001 From: Sohani Rao Date: Thu, 29 Sep 2016 16:20:45 -0700 Subject: [PATCH] Permissions check for Wifi Display configuration Wifi Display is configured using the AIDL call setMiracastMode() and using a message over the async channel SET_WFD_INFO. Enforce permissions on the calling uid before updating the config Bug: 18668877 Test: Unit tests Change-Id: I0be2d2af49070aad759f24bd31331f7df39a0422 Merged-In: I0be2d2af49070aad759f24bd31331f7df39a0422 --- wifi/java/android/net/wifi/p2p/IWifiP2pManager.aidl | 1 + wifi/java/android/net/wifi/p2p/WifiP2pManager.java | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/wifi/java/android/net/wifi/p2p/IWifiP2pManager.aidl b/wifi/java/android/net/wifi/p2p/IWifiP2pManager.aidl index ee2e895af5373..8b1cfaee81191 100644 --- a/wifi/java/android/net/wifi/p2p/IWifiP2pManager.aidl +++ b/wifi/java/android/net/wifi/p2p/IWifiP2pManager.aidl @@ -28,5 +28,6 @@ interface IWifiP2pManager Messenger getMessenger(); Messenger getP2pStateMachineMessenger(); void setMiracastMode(int mode); + void checkConfigureWifiDisplayPermission(); } diff --git a/wifi/java/android/net/wifi/p2p/WifiP2pManager.java b/wifi/java/android/net/wifi/p2p/WifiP2pManager.java index 398308dd2427c..c93ac7b5f8f1b 100644 --- a/wifi/java/android/net/wifi/p2p/WifiP2pManager.java +++ b/wifi/java/android/net/wifi/p2p/WifiP2pManager.java @@ -1324,6 +1324,11 @@ public class WifiP2pManager { Channel c, WifiP2pWfdInfo wfdInfo, ActionListener listener) { checkChannel(c); + try { + mService.checkConfigureWifiDisplayPermission(); + } catch (RemoteException e) { + e.rethrowFromSystemServer(); + } c.mAsyncChannel.sendMessage(SET_WFD_INFO, 0, c.putListener(listener), wfdInfo); }