From ed0a854b0c2bc1a8e9b9c7f28cd87982ef9d129a Mon Sep 17 00:00:00 2001 From: Geoffrey Pitsch Date: Wed, 29 Mar 2017 09:19:50 -0400 Subject: [PATCH] Re-enable throw when notifications posted can't find channel Only applies for non-user builds, and for apps that have tried using channels. Test: runtest systemui-notification Change-Id: I7e28545ba28eadae75bf015bdf490093223e2940 --- .../server/notification/NotificationManagerService.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/services/core/java/com/android/server/notification/NotificationManagerService.java b/services/core/java/com/android/server/notification/NotificationManagerService.java index ede5a5e8e3379..7468b956af4ef 100644 --- a/services/core/java/com/android/server/notification/NotificationManagerService.java +++ b/services/core/java/com/android/server/notification/NotificationManagerService.java @@ -90,6 +90,7 @@ import android.media.AudioManagerInternal; import android.media.IRingtonePlayer; import android.net.Uri; import android.os.Binder; +import android.os.Build; import android.os.Bundle; import android.os.Environment; import android.os.Handler; @@ -3126,8 +3127,9 @@ public class NotificationManagerService extends SystemService { + ", incomingUserId=" + incomingUserId + ", notificationUid=" + notificationUid + ", notification=" + notification; - // STOPSHIP TODO: should throw instead of logging. - // throw new IllegalArgumentException(noChannelStr); + if (Build.IS_DEBUGGABLE) { + throw new IllegalArgumentException(noChannelStr); + } Log.e(TAG, noChannelStr); return; }