From f52773fd62fc2fec40c2e17230b644dfbee6cf2d Mon Sep 17 00:00:00 2001 From: Jeff Sharkey Date: Mon, 28 Jul 2014 16:38:52 -0700 Subject: [PATCH] More DocumentsUI material iteration. Move to using Toolbar for all actions. Drawer contains its own Toolbar with separate title, and hamburger is always visible. Change drawer items to match spec. Switching to Toolbar allows us to remove nasty dialog-on-tablet hacks, yay! This also means we can finally get real IME resizing support. Move to using elevation for all shadows; this removes more nasty hacks around drawing directory shadows. Bug: 15836082 Change-Id: Iba70b898f385a7debd8aabfc98ff39d20bca860d --- packages/DocumentsUI/AndroidManifest.xml | 2 +- .../res/drawable-hdpi/ic_dir_shadow_am.9.png | Bin 184 -> 216 bytes .../res/drawable-mdpi/ic_dir_shadow_am.9.png | Bin 163 -> 197 bytes .../res/drawable-xhdpi/ic_dir_shadow_am.9.png | Bin 193 -> 223 bytes .../drawable-xxhdpi/ic_dir_shadow_am.9.png | Bin 233 -> 260 bytes .../res/drawable/item_activated.xml | 8 +- ...em_root.xml => item_activated_overlay.xml} | 9 +- .../res/layout-sw720dp-land/item_doc_list.xml | 2 +- .../res/layout-sw720dp/activity.xml | 69 ++++--- packages/DocumentsUI/res/layout/activity.xml | 45 ++++- .../res/layout/fragment_directory.xml | 2 +- .../DocumentsUI/res/layout/fragment_pick.xml | 34 +--- .../DocumentsUI/res/layout/fragment_roots.xml | 3 +- .../DocumentsUI/res/layout/fragment_save.xml | 89 ++++----- .../DocumentsUI/res/layout/item_doc_grid.xml | 2 +- .../DocumentsUI/res/layout/item_doc_list.xml | 2 +- packages/DocumentsUI/res/layout/item_root.xml | 32 +-- .../res/layout/item_root_spacer.xml | 12 +- .../{item_title.xml => item_subdir.xml} | 7 +- .../item_subdir_title.xml} | 26 ++- .../DocumentsUI/res/values-sw720dp/dimens.xml | 2 +- packages/DocumentsUI/res/values/colors.xml | 8 +- packages/DocumentsUI/res/values/dimens.xml | 2 + packages/DocumentsUI/res/values/styles.xml | 33 +++- .../documentsui/DirectoryContainerView.java | 8 - .../android/documentsui/DirectoryView.java | 19 +- .../documentsui/DocumentsActivity.java | 183 ++++++++---------- 27 files changed, 323 insertions(+), 276 deletions(-) rename packages/DocumentsUI/res/drawable/{item_root.xml => item_activated_overlay.xml} (73%) rename packages/DocumentsUI/res/layout/{item_title.xml => item_subdir.xml} (87%) rename packages/DocumentsUI/res/{values-sw720dp/styles.xml => layout/item_subdir_title.xml} (51%) diff --git a/packages/DocumentsUI/AndroidManifest.xml b/packages/DocumentsUI/AndroidManifest.xml index 3861cc1b48035..915e2f96efdea 100644 --- a/packages/DocumentsUI/AndroidManifest.xml +++ b/packages/DocumentsUI/AndroidManifest.xml @@ -11,7 +11,7 @@ diff --git a/packages/DocumentsUI/res/drawable-hdpi/ic_dir_shadow_am.9.png b/packages/DocumentsUI/res/drawable-hdpi/ic_dir_shadow_am.9.png index 904d5253672caaa4ebf688b7227f1ffc4886c4c9..d4ffd45d669a68531701b354bc8e4ac763d060ab 100644 GIT binary patch delta 168 zcmV;Z09XIG0oVbMBpd;AQb$4nuFf3k00006VoOIv0RI600RN!9r<0K}7=H(JNliru z-Ul2II3|_5dAqEkdgR delta 135 zcmcb?xPx(m3NK5slV=DA5Y%v_bWC)R$dB@LaSZY3e0#>5tHFS$<)Qsj?xV;5>fbc( znH}I|zUWaNlcHkEz6X^n^@Fb1xZKm)z$9J3kbcg#I&*EQrcy}Tht*o~huC-|3=$4B mFfs!fKLi~v{k<$AIg5Mheg0O9qfb9E0D-5gpUXO@geCx7xHDq_ diff --git a/packages/DocumentsUI/res/drawable-mdpi/ic_dir_shadow_am.9.png b/packages/DocumentsUI/res/drawable-mdpi/ic_dir_shadow_am.9.png index 068619be0b43c378022dc61988c4cbe47f0fa8ee..4a81b6b43c2217f74fdc262b8bf166941f921c40 100644 GIT binary patch delta 148 zcmZ3?c$9I1iVS0Mkh>GZx^prw85kJYlDyqr82*Fcg1yTpPc)RsWiRpcb!ETDE+b%} z%apmm45-T0)5S5w;`G}qib4$rBF+bMmrJn}{I9;o65P)4r(Vx^_2FvANfOy6JUJEx z50BVAXIZ=T3#(UHx3vIVCg!0D8(e AE&u=k delta 114 zcmX@gxR`N*3NK5slV=DA5Y%v_bWC)Rh;sFGaSXBOeS2ynZ-aq|^FeMeUe*o&TV@_K z(VRGm@!#Z_2&-$Xo{P?3zEJq+SU3B13Fa-=ihOol-N?-?t{1c8L%ip-lymIszVIiU S6?&o000f?{elF{r5}E*uz%0}N diff --git a/packages/DocumentsUI/res/drawable-xhdpi/ic_dir_shadow_am.9.png b/packages/DocumentsUI/res/drawable-xhdpi/ic_dir_shadow_am.9.png index e38a8685dcea8ab8d3100c44e3b805bc2b570443..f387132ec17f91b6b1394a955d858ed6bf6d782b 100644 GIT binary patch delta 175 zcmX@ec%N~CiVS0Mkh>GZx^prw85kJYlDyqr82*Fcg1yTpPc)RMXD{*eb!ETDE+b%J zkeGkwJy2D=r;B4q#NoGRtho*t@UUDAJYoNR{~GC~g$jP68%{??w6Ih;#&3!=N?vz- z#dZd<1ZKYnD?YFK{E~0Y(kX8J9dqJtOz`39TYv!`+)qin{(Jcylh*=gM7CRO2U^9z N;pyt>;DOcwwE delta 144 zcmcc5c#v^|3NK5slV=DA5Y%v_bWC)Rs7Us7aSVxQeS5}}tHFVX^lVMQYER`C04xxHn9l*-`PWyL0cdi^W0d zaeOjq#cwUDZ++SGqRfBZ%jBNB(|xp}`ko%oe9GVGv@k$J#Eq*JOyi>Nd&SqN?6a-< j`{hy8>(s3!;t32NzR8t;c;>es=q?6NS3j3^P6 - - + + + + + + diff --git a/packages/DocumentsUI/res/drawable/item_root.xml b/packages/DocumentsUI/res/drawable/item_activated_overlay.xml similarity index 73% rename from packages/DocumentsUI/res/drawable/item_root.xml rename to packages/DocumentsUI/res/drawable/item_activated_overlay.xml index 60d4ab0bb5858..83e4d7e75356d 100644 --- a/packages/DocumentsUI/res/drawable/item_root.xml +++ b/packages/DocumentsUI/res/drawable/item_activated_overlay.xml @@ -15,8 +15,11 @@ --> - - - + + + + + + diff --git a/packages/DocumentsUI/res/layout-sw720dp-land/item_doc_list.xml b/packages/DocumentsUI/res/layout-sw720dp-land/item_doc_list.xml index 5f1e432dac801..95af7e966989a 100644 --- a/packages/DocumentsUI/res/layout-sw720dp-land/item_doc_list.xml +++ b/packages/DocumentsUI/res/layout-sw720dp-land/item_doc_list.xml @@ -17,7 +17,7 @@ + android:background="@drawable/item_activated"> + android:orientation="vertical"> - + + + + + + + - + android:layout_weight="1" + android:orientation="vertical" + android:elevation="8dp" + android:background="@*android:color/material_grey_50"> - + - + - - - + diff --git a/packages/DocumentsUI/res/layout/activity.xml b/packages/DocumentsUI/res/layout/activity.xml index 2ef7e9c1f636c..3ba82e1f1143c 100644 --- a/packages/DocumentsUI/res/layout/activity.xml +++ b/packages/DocumentsUI/res/layout/activity.xml @@ -24,6 +24,23 @@ android:layout_height="match_parent" android:orientation="vertical"> + + + + + + + android:layout_height="wrap_content" + android:background="@*android:color/material_grey_50" + android:elevation="8dp" /> - + android:orientation="vertical" + android:elevation="16dp" + android:background="@*android:color/white"> + + + + + + diff --git a/packages/DocumentsUI/res/layout/fragment_directory.xml b/packages/DocumentsUI/res/layout/fragment_directory.xml index 09b50c0e1b556..ffbd3f037c0f8 100644 --- a/packages/DocumentsUI/res/layout/fragment_directory.xml +++ b/packages/DocumentsUI/res/layout/fragment_directory.xml @@ -17,7 +17,7 @@ + android:background="@*android:color/material_grey_50"> + android:orientation="horizontal" + android:baselineAligned="false" + android:gravity="center_vertical" + android:minHeight="?android:attr/listPreferredItemHeightSmall"> - - - - - -