diff --git a/services/core/java/com/android/server/pm/PackageInstallerSession.java b/services/core/java/com/android/server/pm/PackageInstallerSession.java index 38059772cfd1a..020c23d902be9 100644 --- a/services/core/java/com/android/server/pm/PackageInstallerSession.java +++ b/services/core/java/com/android/server/pm/PackageInstallerSession.java @@ -2406,6 +2406,13 @@ public class PackageInstallerSession extends IPackageInstallerSession.Stub { final VerificationParams verifyingSession = prepareForVerification(); if (isMultiPackage()) { final List childSessions = getChildSessions(); + // Spot check to reject a non-staged multi package install of APEXes and APKs. + if (!params.isStaged && containsApkSession() + && sessionContains(s -> s.isApexSession())) { + throw new PackageManagerException( + PackageManager.INSTALL_FAILED_SESSION_INVALID, + "Non-staged multi package install of APEX and APK packages is not supported"); + } List verifyingChildSessions = new ArrayList<>(childSessions.size()); boolean success = true; @@ -4165,12 +4172,6 @@ public class PackageInstallerSession extends IPackageInstallerSession.Stub { + childSession.sessionId + " and session " + sessionId + " have inconsistent rollback settings"); } - boolean hasAPK = containsApkSession() || !childSession.isApexSession(); - boolean hasAPEX = sessionContains(s -> s.isApexSession()) || childSession.isApexSession(); - if (!params.isStaged && hasAPK && hasAPEX) { - throw new IllegalStateException("Mix of APK and APEX is not supported for " - + "non-staged multi-package session"); - } try { acquireTransactionLock();