From f41853a87ea32ff59a2a22e73e6e763d475334c1 Mon Sep 17 00:00:00 2001 From: Kelly Date: Fri, 28 Oct 2022 14:25:34 +0800 Subject: [PATCH] Fix highlight animation bug. Test: manually on device Bug: 253536111 Change-Id: I52b80080b2af570ee7012f71d7178cbf9e990b68 --- .../android/settingslib/spa/widget/util/EntryHighlight.kt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/widget/util/EntryHighlight.kt b/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/widget/util/EntryHighlight.kt index d09aec9460ddc..e26bdf76e9d65 100644 --- a/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/widget/util/EntryHighlight.kt +++ b/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/widget/util/EntryHighlight.kt @@ -36,14 +36,15 @@ import com.android.settingslib.spa.framework.theme.SettingsTheme @Composable internal fun EntryHighlight(UiLayoutFn: @Composable () -> Unit) { val entryData = LocalEntryDataProvider.current - var isHighlighted by rememberSaveable { mutableStateOf(false) } + val entryIsHighlighted = rememberSaveable { entryData.isHighlighted } + var localHighlighted by rememberSaveable { mutableStateOf(false) } SideEffect { - isHighlighted = entryData.isHighlighted + localHighlighted = entryIsHighlighted } val backgroundColor by animateColorAsState( targetValue = when { - isHighlighted -> MaterialTheme.colorScheme.surfaceVariant + localHighlighted -> MaterialTheme.colorScheme.surfaceVariant else -> SettingsTheme.colorScheme.background }, animationSpec = repeatable(