From 75214cc510c62f936a713c2da3d0a54db9405957 Mon Sep 17 00:00:00 2001 From: Winson Date: Tue, 22 Jun 2021 12:38:56 -0700 Subject: [PATCH] Remove ParsedIntentInfo CREATOR Its existence allows implicit readParcelable calls to invoke a Parcel operation with mismatched read/write data sizes, allowing someone to swap out the data on a reparcel. Internal classes will use writeIntentInfoToParcel, so this is safe to remove. Bug: 191055353 Test: atest com.android.server.pm.test.parsing.parcelling Change-Id: I44faa635faf8a77894a3dda8adf89c10064e53f1 --- .../pm/parsing/component/ParsedIntentInfo.java | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/core/java/android/content/pm/parsing/component/ParsedIntentInfo.java b/core/java/android/content/pm/parsing/component/ParsedIntentInfo.java index 0ba92cc4fef78..504a7bd5a320c 100644 --- a/core/java/android/content/pm/parsing/component/ParsedIntentInfo.java +++ b/core/java/android/content/pm/parsing/component/ParsedIntentInfo.java @@ -19,7 +19,6 @@ package android.content.pm.parsing.component; import android.annotation.Nullable; import android.content.IntentFilter; import android.os.Parcel; -import android.os.Parcelable; import android.util.Pair; import com.android.internal.util.DataClass; @@ -168,19 +167,6 @@ public final class ParsedIntentInfo extends IntentFilter { + '}'; } - public static final Parcelable.Creator CREATOR = - new Parcelable.Creator() { - @Override - public ParsedIntentInfo createFromParcel(Parcel source) { - return new ParsedIntentInfo(source); - } - - @Override - public ParsedIntentInfo[] newArray(int size) { - return new ParsedIntentInfo[size]; - } - }; - public boolean isHasDefault() { return hasDefault; }