Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Ignore BIND_ABOVE_CLIENT for same-process connections"

Browse Source
This commit is contained in:
Treehugger Robot
2023-05-26 16:53:27 +00:00
committed by Gerrit Code Review
parent f315172a7e cd8f5d8b18
commit f3fc703dee
3 changed files with 28 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
services/core/java/com/android/server/am/ActiveServices.java
View File

@@ -2928,7 +2928,9 @@ public final class ActiveServices {
final ProcessServiceRecord clientPsr = b.client.mServices; final ProcessServiceRecord clientPsr = b.client.mServices;
clientPsr.addConnection(c); clientPsr.addConnection(c);
c.startAssociationIfNeeded(); c.startAssociationIfNeeded();
if ((c.flags&Context.BIND_ABOVE_CLIENT) != 0) { // Don't set hasAboveClient if binding to self to prevent modifyRawOomAdj() from
// dropping the process' adjustment level.
if (b.client != s.app && (c.flags & Context.BIND_ABOVE_CLIENT) != 0) {
clientPsr.setHasAboveClient(true); clientPsr.setHasAboveClient(true);
} }
if ((c.flags&Context.BIND_ALLOW_WHITELIST_MANAGEMENT) != 0) { if ((c.flags&Context.BIND_ALLOW_WHITELIST_MANAGEMENT) != 0) {

3
services/core/java/com/android/server/am/ProcessServiceRecord.java
View File

@@ -258,7 +258,8 @@ final class ProcessServiceRecord {
mHasAboveClient = false; mHasAboveClient = false;
for (int i = mConnections.size() - 1; i >= 0; i--) { for (int i = mConnections.size() - 1; i >= 0; i--) {
ConnectionRecord cr = mConnections.valueAt(i); ConnectionRecord cr = mConnections.valueAt(i);
if ((cr.flags & Context.BIND_ABOVE_CLIENT) != 0) { if (cr.binding.service.app.mServices != this
&& (cr.flags & Context.BIND_ABOVE_CLIENT) != 0) {
mHasAboveClient = true; mHasAboveClient = true;
break; break;
} }

23
services/tests/mockingservicestests/src/com/android/server/am/MockingOomAdjusterTests.java
View File

@@ -64,6 +64,7 @@ import static com.android.server.am.ProcessList.UNKNOWN_ADJ;
import static com.android.server.am.ProcessList.VISIBLE_APP_ADJ; import static com.android.server.am.ProcessList.VISIBLE_APP_ADJ;
import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotEquals; import static org.junit.Assert.assertNotEquals;
import static org.junit.Assert.assertTrue; import static org.junit.Assert.assertTrue;
import static org.mockito.AdditionalAnswers.answer; import static org.mockito.AdditionalAnswers.answer;
@@ -2208,6 +2209,28 @@ public class MockingOomAdjusterTests {
assertProcStates(app2, false, PROCESS_STATE_SERVICE, SERVICE_ADJ, "started-services"); assertProcStates(app2, false, PROCESS_STATE_SERVICE, SERVICE_ADJ, "started-services");
} }
@SuppressWarnings("GuardedBy")
@Test
public void testUpdateOomAdj_DoOne_AboveClient_SameProcess() {
ProcessRecord app = spy(makeDefaultProcessRecord(MOCKAPP_PID, MOCKAPP_UID,
MOCKAPP_PROCESSNAME, MOCKAPP_PACKAGENAME, true));
doReturn(PROCESS_STATE_TOP).when(sService.mAtmInternal).getTopProcessState();
doReturn(app).when(sService).getTopApp();
sService.mWakefulness.set(PowerManagerInternal.WAKEFULNESS_AWAKE);
sService.mOomAdjuster.updateOomAdjLocked(app, OomAdjuster.OOM_ADJ_REASON_NONE);
assertEquals(FOREGROUND_APP_ADJ, app.mState.getSetAdj());
// Simulate binding to a service in the same process using BIND_ABOVE_CLIENT and
// verify that its OOM adjustment level is unaffected.
bindService(app, app, null, Context.BIND_ABOVE_CLIENT, mock(IBinder.class));
app.mServices.updateHasAboveClientLocked();
assertFalse(app.mServices.hasAboveClient());
sService.mOomAdjuster.updateOomAdjLocked(app, OomAdjuster.OOM_ADJ_REASON_NONE);
assertEquals(FOREGROUND_APP_ADJ, app.mState.getSetAdj());
}
private ProcessRecord makeDefaultProcessRecord(int pid, int uid, String processName, private ProcessRecord makeDefaultProcessRecord(int pid, int uid, String processName,
String packageName, boolean hasShownUi) { String packageName, boolean hasShownUi) {
long now = SystemClock.uptimeMillis(); long now = SystemClock.uptimeMillis();