From f328bc3a86327f65aa4b434fd4d100a4b30e38bc Mon Sep 17 00:00:00 2001 From: ykhung Date: Thu, 13 Apr 2023 10:30:03 +0800 Subject: [PATCH] Remove plug/unplug condition for the incompatible charging state Remove the plug/unplug condition checking for the incompatible charging state, since system will send the intent again and clear the state directly (https://b.corp.google.com/issues/276403405#comment3) Bug: 276403405 Fix: 276403405 Test: atest KeyguardIndicationControllerTest KeyguardUpdateMonitorTest Change-Id: Ibabbfd047d99bbb5a2e9d6553ea8a708ff797bd0 --- .../com/android/keyguard/KeyguardUpdateMonitor.java | 4 ---- .../android/keyguard/KeyguardUpdateMonitorTest.java | 13 ------------- 2 files changed, 17 deletions(-) diff --git a/packages/SystemUI/src/com/android/keyguard/KeyguardUpdateMonitor.java b/packages/SystemUI/src/com/android/keyguard/KeyguardUpdateMonitor.java index 33a8224408660..b8b7d83d310e4 100644 --- a/packages/SystemUI/src/com/android/keyguard/KeyguardUpdateMonitor.java +++ b/packages/SystemUI/src/com/android/keyguard/KeyguardUpdateMonitor.java @@ -1759,10 +1759,6 @@ public class KeyguardUpdateMonitor implements TrustManager.TrustListener, Dumpab MSG_TIMEZONE_UPDATE, intent.getStringExtra(Intent.EXTRA_TIMEZONE)); mHandler.sendMessage(msg); } else if (Intent.ACTION_BATTERY_CHANGED.equals(action)) { - // Clear incompatible charger state when device is unplugged. - if (!BatteryStatus.isPluggedIn(intent)) { - mIncompatibleCharger = false; - } final Message msg = mHandler.obtainMessage( MSG_BATTERY_UPDATE, new BatteryStatus(intent, mIncompatibleCharger)); mHandler.sendMessage(msg); diff --git a/packages/SystemUI/tests/src/com/android/keyguard/KeyguardUpdateMonitorTest.java b/packages/SystemUI/tests/src/com/android/keyguard/KeyguardUpdateMonitorTest.java index 3eb9590c0b952..db86ac6fbb0da 100644 --- a/packages/SystemUI/tests/src/com/android/keyguard/KeyguardUpdateMonitorTest.java +++ b/packages/SystemUI/tests/src/com/android/keyguard/KeyguardUpdateMonitorTest.java @@ -2527,19 +2527,6 @@ public class KeyguardUpdateMonitorTest extends SysuiTestCase { assertThat(mKeyguardUpdateMonitor.mIncompatibleCharger).isTrue(); } - @Test - public void testBatteryChangedIntent_unplugDevice_resetIncompatibleCharger() { - mKeyguardUpdateMonitor.mIncompatibleCharger = true; - Intent batteryChangedIntent = - getBatteryIntent().putExtra(BatteryManager.EXTRA_PLUGGED, -1); - - mKeyguardUpdateMonitor.mBroadcastReceiver.onReceive(mContext, batteryChangedIntent); - - BatteryStatus status = verifyRefreshBatteryInfo(); - assertThat(status.incompatibleCharger.get()).isFalse(); - assertThat(mKeyguardUpdateMonitor.mIncompatibleCharger).isFalse(); - } - @Test public void unfoldWakeup_requestActiveUnlock_forceDismissKeyguard() throws RemoteException {