Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge change 2468 into donut

Browse Source 
* changes:
  setVolume did not check interface descriptor DO NOT MERGE
This commit is contained in:
Android (Google) Code Review
2009-05-26 16:23:08 -07:00
parent fdacdcb654 814941997f
commit f3288f178a
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
media/libmedia/IMediaPlayer.cpp
View File

@@ -164,6 +164,7 @@ public:
status_t setVolume(float leftVolume, float rightVolume) status_t setVolume(float leftVolume, float rightVolume)
{ {
Parcel data, reply; Parcel data, reply;
data.writeInterfaceToken(IMediaPlayer::getInterfaceDescriptor());
data.writeFloat(leftVolume); data.writeFloat(leftVolume);
data.writeFloat(rightVolume); data.writeFloat(rightVolume);
remote()->transact(SET_VOLUME, data, &reply); remote()->transact(SET_VOLUME, data, &reply);
@@ -261,6 +262,7 @@ status_t BnMediaPlayer::onTransact(
return NO_ERROR; return NO_ERROR;
} break; } break;
case SET_VOLUME: { case SET_VOLUME: {
CHECK_INTERFACE(IMediaPlayer, data, reply);
reply->writeInt32(setVolume(data.readFloat(), data.readFloat())); reply->writeInt32(setVolume(data.readFloat(), data.readFloat()));
return NO_ERROR; return NO_ERROR;
} break; } break;