From f324eaba3cf8b66c940ec4ccfcefbda5e8581968 Mon Sep 17 00:00:00 2001 From: Yohei Yukawa Date: Thu, 13 Oct 2022 23:06:47 -0700 Subject: [PATCH] Merge updateImeFocusable() into onPostWindowFocus() This is mechanical refactoring. There must be no behavior change. Bug: 234882948 Test: presubmit Change-Id: I49665b3832de75238243227acc76be58dceb50fc --- core/java/android/view/ImeFocusController.java | 6 +----- core/java/android/view/ViewRootImpl.java | 1 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/core/java/android/view/ImeFocusController.java b/core/java/android/view/ImeFocusController.java index 455f4a76834e1..fa647d7e9c004 100644 --- a/core/java/android/view/ImeFocusController.java +++ b/core/java/android/view/ImeFocusController.java @@ -84,17 +84,13 @@ public final class ImeFocusController { @UiThread void onPreWindowFocus(boolean hasWindowFocus, WindowManager.LayoutParams windowAttribute) { + mHasImeFocus = WindowManager.LayoutParams.mayUseInputMethod(windowAttribute.flags); if (!hasWindowFocus || !mHasImeFocus || isInLocalFocusMode(windowAttribute)) { return; } getImmDelegate().onPreWindowGainedFocus(mViewRootImpl); } - @UiThread - void updateImeFocusable(WindowManager.LayoutParams windowAttribute) { - mHasImeFocus = WindowManager.LayoutParams.mayUseInputMethod(windowAttribute.flags); - } - @UiThread void onPostWindowFocus(View focusedView, boolean hasWindowFocus, WindowManager.LayoutParams windowAttribute) { diff --git a/core/java/android/view/ViewRootImpl.java b/core/java/android/view/ViewRootImpl.java index b690b3c5098cb..fd56463f512bb 100644 --- a/core/java/android/view/ViewRootImpl.java +++ b/core/java/android/view/ViewRootImpl.java @@ -3798,7 +3798,6 @@ public final class ViewRootImpl implements ViewParent, } mAttachInfo.mHasWindowFocus = hasWindowFocus; - mImeFocusController.updateImeFocusable(mWindowAttributes); mImeFocusController.onPreWindowFocus(hasWindowFocus, mWindowAttributes); if (mView != null) {