Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

am c8c5884d: am 0c3aa483: Merge "Remove hex encoding and password adjusting now that patterns are \'1\' based" into mnc-dev

Browse Source 
* commit 'c8c5884d976f599efd3aef3b64aa42f3072947b1':
  Remove hex encoding and password adjusting now that patterns are '1' based
This commit is contained in:
Paul Lawrence
2015-06-10 16:06:09 +00:00
committed by Android Git Automerger
parent bb2f798ae1 c8c5884d97
commit f31bd09afc
1 changed files with 5 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
services/core/java/com/android/server/MountService.java
View File

@@ -76,7 +76,6 @@ import android.util.Xml;
import libcore.io.IoUtils; import libcore.io.IoUtils;
import libcore.util.EmptyArray; import libcore.util.EmptyArray;
import libcore.util.HexEncoding;
import com.android.internal.annotations.GuardedBy; import com.android.internal.annotations.GuardedBy;
import com.android.internal.annotations.VisibleForTesting; import com.android.internal.annotations.VisibleForTesting;
@@ -2078,23 +2077,6 @@ class MountService extends IMountService.Stub
} }
} }
private static String toHex(String password) {
if (password == null) {
return "";
}
byte[] bytes = password.getBytes(StandardCharsets.UTF_8);
return new String(HexEncoding.encode(bytes));
}
private static String fromHex(String hexPassword) throws IllegalArgumentException {
if (hexPassword == null) {
return null;
}
final byte[] bytes = HexEncoding.decode(hexPassword.toCharArray(), false);
return new String(bytes, StandardCharsets.UTF_8);
}
@Override @Override
public int decryptStorage(String password) { public int decryptStorage(String password) {
if (TextUtils.isEmpty(password)) { if (TextUtils.isEmpty(password)) {
@@ -2112,7 +2094,7 @@ class MountService extends IMountService.Stub
final NativeDaemonEvent event; final NativeDaemonEvent event;
try { try {
event = mCryptConnector.execute("cryptfs", "checkpw", new SensitiveArg(toHex(password))); event = mCryptConnector.execute("cryptfs", "checkpw", new SensitiveArg(password));
final int code = Integer.parseInt(event.getMessage()); final int code = Integer.parseInt(event.getMessage());
if (code == 0) { if (code == 0) {
@@ -2152,7 +2134,7 @@ class MountService extends IMountService.Stub
try { try {
mCryptConnector.execute("cryptfs", "enablecrypto", "inplace", CRYPTO_TYPES[type], mCryptConnector.execute("cryptfs", "enablecrypto", "inplace", CRYPTO_TYPES[type],
new SensitiveArg(toHex(password))); new SensitiveArg(password));
} catch (NativeDaemonConnectorException e) { } catch (NativeDaemonConnectorException e) {
// Encryption failed // Encryption failed
return e.getCode(); return e.getCode();
@@ -2177,7 +2159,7 @@ class MountService extends IMountService.Stub
try { try {
NativeDaemonEvent event = mCryptConnector.execute("cryptfs", "changepw", CRYPTO_TYPES[type], NativeDaemonEvent event = mCryptConnector.execute("cryptfs", "changepw", CRYPTO_TYPES[type],
new SensitiveArg(toHex(password))); new SensitiveArg(password));
return Integer.parseInt(event.getMessage()); return Integer.parseInt(event.getMessage());
} catch (NativeDaemonConnectorException e) { } catch (NativeDaemonConnectorException e) {
// Encryption failed // Encryption failed
@@ -2210,7 +2192,7 @@ class MountService extends IMountService.Stub
final NativeDaemonEvent event; final NativeDaemonEvent event;
try { try {
event = mCryptConnector.execute("cryptfs", "verifypw", new SensitiveArg(toHex(password))); event = mCryptConnector.execute("cryptfs", "verifypw", new SensitiveArg(password));
Slog.i(TAG, "cryptfs verifypw => " + event.getMessage()); Slog.i(TAG, "cryptfs verifypw => " + event.getMessage());
return Integer.parseInt(event.getMessage()); return Integer.parseInt(event.getMessage());
} catch (NativeDaemonConnectorException e) { } catch (NativeDaemonConnectorException e) {
@@ -2300,7 +2282,7 @@ class MountService extends IMountService.Stub
// -1 equals no password // -1 equals no password
return null; return null;
} }
return fromHex(event.getMessage()); return event.getMessage();
} catch (NativeDaemonConnectorException e) { } catch (NativeDaemonConnectorException e) {
throw e.rethrowAsParcelableException(); throw e.rethrowAsParcelableException();
} catch (IllegalArgumentException e) { } catch (IllegalArgumentException e) {