Replace StatusBarKeyguardViewManager with KeyguardViewController
Not all Android verticals use the StatusBarKeyguardViewManager. To prevent breakages on these alternative platforms, the more generic KeyguardViewController should be used instead. Bug: 214617520 Test: manual (on oriole & oriole_car), atest MediaHierarchyManagerTest Change-Id: I07739b5763f78580475476aa81d5d1297f956fde Merged-In: I07739b5763f78580475476aa81d5d1297f956fde
This commit is contained in:
@@ -28,6 +28,7 @@ import android.view.View
|
|||||||
import android.view.ViewGroup
|
import android.view.ViewGroup
|
||||||
import android.view.ViewGroupOverlay
|
import android.view.ViewGroupOverlay
|
||||||
import androidx.annotation.VisibleForTesting
|
import androidx.annotation.VisibleForTesting
|
||||||
|
import com.android.keyguard.KeyguardViewController
|
||||||
import com.android.systemui.R
|
import com.android.systemui.R
|
||||||
import com.android.systemui.animation.Interpolators
|
import com.android.systemui.animation.Interpolators
|
||||||
import com.android.systemui.dagger.SysUISingleton
|
import com.android.systemui.dagger.SysUISingleton
|
||||||
@@ -39,7 +40,6 @@ import com.android.systemui.statusbar.StatusBarState
|
|||||||
import com.android.systemui.statusbar.SysuiStatusBarStateController
|
import com.android.systemui.statusbar.SysuiStatusBarStateController
|
||||||
import com.android.systemui.statusbar.notification.stack.StackStateAnimator
|
import com.android.systemui.statusbar.notification.stack.StackStateAnimator
|
||||||
import com.android.systemui.statusbar.phone.KeyguardBypassController
|
import com.android.systemui.statusbar.phone.KeyguardBypassController
|
||||||
import com.android.systemui.statusbar.phone.StatusBarKeyguardViewManager
|
|
||||||
import com.android.systemui.statusbar.policy.ConfigurationController
|
import com.android.systemui.statusbar.policy.ConfigurationController
|
||||||
import com.android.systemui.statusbar.policy.KeyguardStateController
|
import com.android.systemui.statusbar.policy.KeyguardStateController
|
||||||
import com.android.systemui.util.Utils
|
import com.android.systemui.util.Utils
|
||||||
@@ -82,7 +82,7 @@ class MediaHierarchyManager @Inject constructor(
|
|||||||
private val notifLockscreenUserManager: NotificationLockscreenUserManager,
|
private val notifLockscreenUserManager: NotificationLockscreenUserManager,
|
||||||
configurationController: ConfigurationController,
|
configurationController: ConfigurationController,
|
||||||
wakefulnessLifecycle: WakefulnessLifecycle,
|
wakefulnessLifecycle: WakefulnessLifecycle,
|
||||||
private val statusBarKeyguardViewManager: StatusBarKeyguardViewManager
|
private val keyguardViewController: KeyguardViewController
|
||||||
) {
|
) {
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -998,7 +998,7 @@ class MediaHierarchyManager @Inject constructor(
|
|||||||
|
|
||||||
private fun isLockScreenVisibleToUser(): Boolean {
|
private fun isLockScreenVisibleToUser(): Boolean {
|
||||||
return !statusBarStateController.isDozing &&
|
return !statusBarStateController.isDozing &&
|
||||||
!statusBarKeyguardViewManager.isBouncerShowing &&
|
!keyguardViewController.isBouncerShowing &&
|
||||||
statusBarStateController.state == StatusBarState.KEYGUARD &&
|
statusBarStateController.state == StatusBarState.KEYGUARD &&
|
||||||
notifLockscreenUserManager.shouldShowLockscreenNotifications() &&
|
notifLockscreenUserManager.shouldShowLockscreenNotifications() &&
|
||||||
statusBarStateController.isExpanded &&
|
statusBarStateController.isExpanded &&
|
||||||
@@ -1007,7 +1007,7 @@ class MediaHierarchyManager @Inject constructor(
|
|||||||
|
|
||||||
private fun isLockScreenShadeVisibleToUser(): Boolean {
|
private fun isLockScreenShadeVisibleToUser(): Boolean {
|
||||||
return !statusBarStateController.isDozing &&
|
return !statusBarStateController.isDozing &&
|
||||||
!statusBarKeyguardViewManager.isBouncerShowing &&
|
!keyguardViewController.isBouncerShowing &&
|
||||||
(statusBarStateController.state == StatusBarState.SHADE_LOCKED ||
|
(statusBarStateController.state == StatusBarState.SHADE_LOCKED ||
|
||||||
(statusBarStateController.state == StatusBarState.KEYGUARD && qsExpanded))
|
(statusBarStateController.state == StatusBarState.KEYGUARD && qsExpanded))
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -22,6 +22,7 @@ import android.testing.TestableLooper
|
|||||||
import android.view.ViewGroup
|
import android.view.ViewGroup
|
||||||
import android.widget.FrameLayout
|
import android.widget.FrameLayout
|
||||||
import androidx.test.filters.SmallTest
|
import androidx.test.filters.SmallTest
|
||||||
|
import com.android.keyguard.KeyguardViewController
|
||||||
import com.android.systemui.R
|
import com.android.systemui.R
|
||||||
import com.android.systemui.SysuiTestCase
|
import com.android.systemui.SysuiTestCase
|
||||||
import com.android.systemui.controls.controller.ControlsControllerImplTest.Companion.eq
|
import com.android.systemui.controls.controller.ControlsControllerImplTest.Companion.eq
|
||||||
@@ -31,7 +32,6 @@ import com.android.systemui.statusbar.NotificationLockscreenUserManager
|
|||||||
import com.android.systemui.statusbar.StatusBarState
|
import com.android.systemui.statusbar.StatusBarState
|
||||||
import com.android.systemui.statusbar.SysuiStatusBarStateController
|
import com.android.systemui.statusbar.SysuiStatusBarStateController
|
||||||
import com.android.systemui.statusbar.phone.KeyguardBypassController
|
import com.android.systemui.statusbar.phone.KeyguardBypassController
|
||||||
import com.android.systemui.statusbar.phone.StatusBarKeyguardViewManager
|
|
||||||
import com.android.systemui.statusbar.policy.ConfigurationController
|
import com.android.systemui.statusbar.policy.ConfigurationController
|
||||||
import com.android.systemui.statusbar.policy.KeyguardStateController
|
import com.android.systemui.statusbar.policy.KeyguardStateController
|
||||||
import com.android.systemui.util.animation.UniqueObjectHostView
|
import com.android.systemui.util.animation.UniqueObjectHostView
|
||||||
@@ -80,7 +80,7 @@ class MediaHierarchyManagerTest : SysuiTestCase() {
|
|||||||
@Mock
|
@Mock
|
||||||
private lateinit var wakefulnessLifecycle: WakefulnessLifecycle
|
private lateinit var wakefulnessLifecycle: WakefulnessLifecycle
|
||||||
@Mock
|
@Mock
|
||||||
private lateinit var statusBarKeyguardViewManager: StatusBarKeyguardViewManager
|
private lateinit var keyguardViewController: KeyguardViewController
|
||||||
@Mock
|
@Mock
|
||||||
private lateinit var configurationController: ConfigurationController
|
private lateinit var configurationController: ConfigurationController
|
||||||
@Mock
|
@Mock
|
||||||
@@ -110,7 +110,7 @@ class MediaHierarchyManagerTest : SysuiTestCase() {
|
|||||||
notificationLockscreenUserManager,
|
notificationLockscreenUserManager,
|
||||||
configurationController,
|
configurationController,
|
||||||
wakefulnessLifecycle,
|
wakefulnessLifecycle,
|
||||||
statusBarKeyguardViewManager)
|
keyguardViewController)
|
||||||
verify(wakefulnessLifecycle).addObserver(wakefullnessObserver.capture())
|
verify(wakefulnessLifecycle).addObserver(wakefullnessObserver.capture())
|
||||||
verify(statusBarStateController).addCallback(statusBarCallback.capture())
|
verify(statusBarStateController).addCallback(statusBarCallback.capture())
|
||||||
setupHost(lockHost, MediaHierarchyManager.LOCATION_LOCKSCREEN)
|
setupHost(lockHost, MediaHierarchyManager.LOCATION_LOCKSCREEN)
|
||||||
|
|||||||
Reference in New Issue
Block a user