From fd48ed6669f490369fdade9a356028838d290fcd Mon Sep 17 00:00:00 2001 From: Vladislav Kaznacheev Date: Tue, 2 May 2017 09:39:06 -0700 Subject: [PATCH] Fix VideoView touch and trackball handlers to call super. Currently VideoView.onTouchEvent and VideoView.onTrackballEvent do not call super. This completely disables several useful View features such as long click, context menu or tooltips. Bug: 37755662 Test: manual Change-Id: I0c82c32da36e4ca7cacc78027daed2fa298a6b58 --- core/java/android/widget/VideoView.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/core/java/android/widget/VideoView.java b/core/java/android/widget/VideoView.java index 7b2efeac75fc8..58a2b0f00877d 100644 --- a/core/java/android/widget/VideoView.java +++ b/core/java/android/widget/VideoView.java @@ -708,18 +708,20 @@ public class VideoView extends SurfaceView @Override public boolean onTouchEvent(MotionEvent ev) { - if (isInPlaybackState() && mMediaController != null) { + if (ev.getAction() == MotionEvent.ACTION_DOWN + && isInPlaybackState() && mMediaController != null) { toggleMediaControlsVisiblity(); } - return false; + return super.onTouchEvent(ev); } @Override public boolean onTrackballEvent(MotionEvent ev) { - if (isInPlaybackState() && mMediaController != null) { + if (ev.getAction() == MotionEvent.ACTION_DOWN + && isInPlaybackState() && mMediaController != null) { toggleMediaControlsVisiblity(); } - return false; + return super.onTrackballEvent(ev); } @Override