From f187670270e360395a3a2013eb58e97237f32b8a Mon Sep 17 00:00:00 2001 From: Nate Myren Date: Thu, 11 Feb 2021 12:40:48 -0800 Subject: [PATCH] Fix double adding of special attribution usage Fixes: 180019623 Test: manual Change-Id: I6e0681e0126bc563d8af4cd11c7db0785e47c912 --- core/java/android/permission/PermissionUsageHelper.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/core/java/android/permission/PermissionUsageHelper.java b/core/java/android/permission/PermissionUsageHelper.java index 85e9fdb9a9d17..0e35ef98f1b78 100644 --- a/core/java/android/permission/PermissionUsageHelper.java +++ b/core/java/android/permission/PermissionUsageHelper.java @@ -693,13 +693,14 @@ public class PermissionUsageHelper { for (int usageNum = 0; usageNum < rawUsages.size(); usageNum++) { OpUsage usage = rawUsages.get(usageNum); + // If this attribution is a proxy, remove it + if (toRemoveProxies.contains(usage.toPackageAttr())) { + continue; + } + // If this attribution has a special attribution, do not remove it if (specialAttributions.contains(usage.toPackageAttr())) { deDuped.add(usage); - } - - // If this attribution is a proxy, remove it - if (toRemoveProxies.contains(usage.toPackageAttr())) { continue; }