Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Do not show SMS SIM pick UI for Cell Broadcast Config change"

Browse Source 
am: 4ae4e50def

Change-Id: Iefa6fdcfaa5e3efbfebcf403d284acf569d45ab2
This commit is contained in:
Brad Ebinger
2019-03-29 16:23:24 -07:00
committed by android-build-merger
parent 1c906d426d 4ae4e50def
commit f15dabde00
1 changed files with 22 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
telephony/java/android/telephony/SmsManager.java
View File

@@ -941,8 +941,7 @@ public final class SmsManager {
* @return associated subscription id
*/
public int getSubscriptionId() {
final int subId = (mSubId == DEFAULT_SUBSCRIPTION_ID)
? getDefaultSmsSubscriptionId() : mSubId;
final int subId = getSubIdOrDefault();
boolean isSmsSimPickActivityNeeded = false;
final Context context = ActivityThread.currentApplication().getApplicationContext();
try {
@@ -974,6 +973,17 @@ public final class SmsManager {
return subId;
}
/**
* @return the subscription ID associated with this {@link SmsManager} or the default set by the
* user if this instance was created using {@link SmsManager#getDefault}.
*
* If there is no default set by the user, this method returns
* {@link SubscriptionManager#INVALID_SUBSCRIPTION_ID}.
*/
private int getSubIdOrDefault() {
return (mSubId == DEFAULT_SUBSCRIPTION_ID) ? getDefaultSmsSubscriptionId() : mSubId;
}
/**
* Returns the ISms service, or throws an UnsupportedOperationException if
* the service does not exist.
@@ -1141,8 +1151,9 @@ public final class SmsManager {
try {
ISms iSms = getISmsService();
if (iSms != null) {
success = iSms.enableCellBroadcastForSubscriber(
getSubscriptionId(), messageIdentifier, ranType);
// If getSubIdOrDefault() returns INVALID, we will use the default phone internally.
success = iSms.enableCellBroadcastForSubscriber(getSubIdOrDefault(),
messageIdentifier, ranType);
}
} catch (RemoteException ex) {
// ignore it
@@ -1177,8 +1188,9 @@ public final class SmsManager {
try {
ISms iSms = getISmsService();
if (iSms != null) {
success = iSms.disableCellBroadcastForSubscriber(
getSubscriptionId(), messageIdentifier, ranType);
// If getSubIdOrDefault() returns INVALID, we will use the default phone internally.
success = iSms.disableCellBroadcastForSubscriber(getSubIdOrDefault(),
messageIdentifier, ranType);
}
} catch (RemoteException ex) {
// ignore it
@@ -1220,7 +1232,8 @@ public final class SmsManager {
try {
ISms iSms = getISmsService();
if (iSms != null) {
success = iSms.enableCellBroadcastRangeForSubscriber(getSubscriptionId(),
// If getSubIdOrDefault() returns INVALID, we will use the default phone internally.
success = iSms.enableCellBroadcastRangeForSubscriber(getSubIdOrDefault(),
startMessageId, endMessageId, ranType);
}
} catch (RemoteException ex) {
@@ -1263,7 +1276,8 @@ public final class SmsManager {
try {
ISms iSms = getISmsService();
if (iSms != null) {
success = iSms.disableCellBroadcastRangeForSubscriber(getSubscriptionId(),
// If getSubIdOrDefault() returns INVALID, we will use the default phone internally.
success = iSms.disableCellBroadcastRangeForSubscriber(getSubIdOrDefault(),
startMessageId, endMessageId, ranType);
}
} catch (RemoteException ex) {