From 4fa85b7cadfb2a2e8584f99a8b316f33d56bee75 Mon Sep 17 00:00:00 2001 From: Jeff Sharkey Date: Mon, 20 Jul 2015 09:38:02 -0700 Subject: [PATCH] Better logging of MediaPlayer failure reason. Otherwise exception details are dropped on the floor, making it hard to debug. Bug: 22525550 Change-Id: I6ab9eb8461a23b9d9b8a0ea6dd1ae8ee2495dd01 --- media/java/android/media/MediaPlayer.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/media/java/android/media/MediaPlayer.java b/media/java/android/media/MediaPlayer.java index 6dd855d4dc410..a4d3485e890a9 100644 --- a/media/java/android/media/MediaPlayer.java +++ b/media/java/android/media/MediaPlayer.java @@ -1017,16 +1017,14 @@ public class MediaPlayer implements SubtitleController.Listener setDataSource(fd.getFileDescriptor(), fd.getStartOffset(), fd.getDeclaredLength()); } return; - } catch (SecurityException ex) { - } catch (IOException ex) { + } catch (SecurityException | IOException ex) { + Log.w(TAG, "Couldn't open file on client side; trying server side: " + ex); } finally { if (fd != null) { fd.close(); } } - Log.d(TAG, "Couldn't open file on client side, trying server side"); - setDataSource(uri.toString(), headers); }