From efc90dbda6e163579d93808c74ae8ceef6dc8b05 Mon Sep 17 00:00:00 2001 From: Hongwei Wang Date: Fri, 7 Dec 2018 11:30:08 -0800 Subject: [PATCH] Use new CarAudioManager.registerCarVolumeCallback API Per API review, we deprecated the following APIs - registerVolumeCallback(IBinder) - unregisterVolumeCallback(IBinder) Bug: 120629164 Test: Volume bar shows when changing volume on emulator Change-Id: I119ac96033cdf8dc1b0cf66ef2440b4e9572157f --- .../android/systemui/volume/CarVolumeDialogImpl.java | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/packages/CarSystemUI/src/com/android/systemui/volume/CarVolumeDialogImpl.java b/packages/CarSystemUI/src/com/android/systemui/volume/CarVolumeDialogImpl.java index d08717678dba5..1737b644f5d39 100644 --- a/packages/CarSystemUI/src/com/android/systemui/volume/CarVolumeDialogImpl.java +++ b/packages/CarSystemUI/src/com/android/systemui/volume/CarVolumeDialogImpl.java @@ -26,7 +26,6 @@ import android.app.KeyguardManager; import android.car.Car; import android.car.CarNotConnectedException; import android.car.media.CarAudioManager; -import android.car.media.ICarVolumeCallback; import android.content.ComponentName; import android.content.Context; import android.content.DialogInterface; @@ -106,7 +105,8 @@ public class CarVolumeDialogImpl implements VolumeDialog { private ListItemAdapter mPagedListAdapter; private Car mCar; private CarAudioManager mCarAudioManager; - private final ICarVolumeCallback mVolumeChangeCallback = new ICarVolumeCallback.Stub() { + private final CarAudioManager.CarVolumeCallback mVolumeChangeCallback = + new CarAudioManager.CarVolumeCallback() { @Override public void onGroupVolumeChanged(int zoneId, int groupId, int flags) { // TODO: Include zoneId into consideration. @@ -162,7 +162,7 @@ public class CarVolumeDialogImpl implements VolumeDialog { if (mPagedListAdapter != null) { mPagedListAdapter.notifyDataSetChanged(); } - mCarAudioManager.registerVolumeCallback(mVolumeChangeCallback.asBinder()); + mCarAudioManager.registerCarVolumeCallback(mVolumeChangeCallback); } catch (CarNotConnectedException e) { Log.e(TAG, "Car is not connected!", e); } @@ -440,11 +440,7 @@ public class CarVolumeDialogImpl implements VolumeDialog { } private void cleanupAudioManager() { - try { - mCarAudioManager.unregisterVolumeCallback(mVolumeChangeCallback.asBinder()); - } catch (CarNotConnectedException e) { - Log.e(TAG, "Car is not connected!", e); - } + mCarAudioManager.unregisterCarVolumeCallback(mVolumeChangeCallback); mVolumeLineItems.clear(); mCarAudioManager = null; }