diff --git a/tools/layoutlib/bridge/src/android/graphics/Bitmap_Delegate.java b/tools/layoutlib/bridge/src/android/graphics/Bitmap_Delegate.java index b6d5725ab07b6..66e59d8655340 100644 --- a/tools/layoutlib/bridge/src/android/graphics/Bitmap_Delegate.java +++ b/tools/layoutlib/bridge/src/android/graphics/Bitmap_Delegate.java @@ -54,7 +54,7 @@ public final class Bitmap_Delegate { // ---- delegate manager ---- private static final DelegateManager sManager = - new DelegateManager(); + new DelegateManager(Bitmap_Delegate.class); // ---- delegate helper data ---- diff --git a/tools/layoutlib/bridge/src/android/graphics/Canvas_Delegate.java b/tools/layoutlib/bridge/src/android/graphics/Canvas_Delegate.java index f0e727febe961..4decd1a515e17 100644 --- a/tools/layoutlib/bridge/src/android/graphics/Canvas_Delegate.java +++ b/tools/layoutlib/bridge/src/android/graphics/Canvas_Delegate.java @@ -54,7 +54,7 @@ public final class Canvas_Delegate { // ---- delegate manager ---- private static final DelegateManager sManager = - new DelegateManager(); + new DelegateManager(Canvas_Delegate.class); // ---- delegate helper data ---- diff --git a/tools/layoutlib/bridge/src/android/graphics/ColorFilter_Delegate.java b/tools/layoutlib/bridge/src/android/graphics/ColorFilter_Delegate.java index e786eb587b1db..e5a7ab6d0d234 100644 --- a/tools/layoutlib/bridge/src/android/graphics/ColorFilter_Delegate.java +++ b/tools/layoutlib/bridge/src/android/graphics/ColorFilter_Delegate.java @@ -38,7 +38,7 @@ public abstract class ColorFilter_Delegate { // ---- delegate manager ---- protected static final DelegateManager sManager = - new DelegateManager(); + new DelegateManager(ColorFilter_Delegate.class); // ---- delegate helper data ---- diff --git a/tools/layoutlib/bridge/src/android/graphics/DrawFilter_Delegate.java b/tools/layoutlib/bridge/src/android/graphics/DrawFilter_Delegate.java index 37c7359b5814f..870c46b8f5dd1 100644 --- a/tools/layoutlib/bridge/src/android/graphics/DrawFilter_Delegate.java +++ b/tools/layoutlib/bridge/src/android/graphics/DrawFilter_Delegate.java @@ -38,7 +38,7 @@ public abstract class DrawFilter_Delegate { // ---- delegate manager ---- protected static final DelegateManager sManager = - new DelegateManager(); + new DelegateManager(DrawFilter_Delegate.class); // ---- delegate helper data ---- diff --git a/tools/layoutlib/bridge/src/android/graphics/MaskFilter_Delegate.java b/tools/layoutlib/bridge/src/android/graphics/MaskFilter_Delegate.java index 5a6167dc6a3dc..c2f27e43c7bf5 100644 --- a/tools/layoutlib/bridge/src/android/graphics/MaskFilter_Delegate.java +++ b/tools/layoutlib/bridge/src/android/graphics/MaskFilter_Delegate.java @@ -38,7 +38,7 @@ public abstract class MaskFilter_Delegate { // ---- delegate manager ---- protected static final DelegateManager sManager = - new DelegateManager(); + new DelegateManager(MaskFilter_Delegate.class); // ---- delegate helper data ---- diff --git a/tools/layoutlib/bridge/src/android/graphics/Matrix_Delegate.java b/tools/layoutlib/bridge/src/android/graphics/Matrix_Delegate.java index 251aa16ba48b4..451edd2f430d9 100644 --- a/tools/layoutlib/bridge/src/android/graphics/Matrix_Delegate.java +++ b/tools/layoutlib/bridge/src/android/graphics/Matrix_Delegate.java @@ -46,7 +46,7 @@ public final class Matrix_Delegate { // ---- delegate manager ---- private static final DelegateManager sManager = - new DelegateManager(); + new DelegateManager(Matrix_Delegate.class); // ---- delegate data ---- private float mValues[] = new float[MATRIX_SIZE]; diff --git a/tools/layoutlib/bridge/src/android/graphics/Paint_Delegate.java b/tools/layoutlib/bridge/src/android/graphics/Paint_Delegate.java index 51b3efe12cd7a..373f48249cff2 100644 --- a/tools/layoutlib/bridge/src/android/graphics/Paint_Delegate.java +++ b/tools/layoutlib/bridge/src/android/graphics/Paint_Delegate.java @@ -62,7 +62,7 @@ public class Paint_Delegate { // ---- delegate manager ---- private static final DelegateManager sManager = - new DelegateManager(); + new DelegateManager(Paint_Delegate.class); // ---- delegate helper data ---- private List mFonts; diff --git a/tools/layoutlib/bridge/src/android/graphics/PathEffect_Delegate.java b/tools/layoutlib/bridge/src/android/graphics/PathEffect_Delegate.java index 4d5311af42aec..bd2b6de480da2 100644 --- a/tools/layoutlib/bridge/src/android/graphics/PathEffect_Delegate.java +++ b/tools/layoutlib/bridge/src/android/graphics/PathEffect_Delegate.java @@ -40,7 +40,7 @@ public abstract class PathEffect_Delegate { // ---- delegate manager ---- protected static final DelegateManager sManager = - new DelegateManager(); + new DelegateManager(PathEffect_Delegate.class); // ---- delegate helper data ---- diff --git a/tools/layoutlib/bridge/src/android/graphics/Path_Delegate.java b/tools/layoutlib/bridge/src/android/graphics/Path_Delegate.java index c29e9b6a0142a..6c9f48fb003c0 100644 --- a/tools/layoutlib/bridge/src/android/graphics/Path_Delegate.java +++ b/tools/layoutlib/bridge/src/android/graphics/Path_Delegate.java @@ -50,7 +50,7 @@ public final class Path_Delegate { // ---- delegate manager ---- private static final DelegateManager sManager = - new DelegateManager(); + new DelegateManager(Path_Delegate.class); // ---- delegate data ---- private FillType mFillType = FillType.WINDING; diff --git a/tools/layoutlib/bridge/src/android/graphics/Rasterizer_Delegate.java b/tools/layoutlib/bridge/src/android/graphics/Rasterizer_Delegate.java index e388bd9fc1b0d..2812b6b2539bd 100644 --- a/tools/layoutlib/bridge/src/android/graphics/Rasterizer_Delegate.java +++ b/tools/layoutlib/bridge/src/android/graphics/Rasterizer_Delegate.java @@ -38,7 +38,7 @@ public abstract class Rasterizer_Delegate { // ---- delegate manager ---- protected static final DelegateManager sManager = - new DelegateManager(); + new DelegateManager(Rasterizer_Delegate.class); // ---- delegate helper data ---- diff --git a/tools/layoutlib/bridge/src/android/graphics/Region_Delegate.java b/tools/layoutlib/bridge/src/android/graphics/Region_Delegate.java index 91f4347482ab6..cb31b8fdb7115 100644 --- a/tools/layoutlib/bridge/src/android/graphics/Region_Delegate.java +++ b/tools/layoutlib/bridge/src/android/graphics/Region_Delegate.java @@ -48,7 +48,7 @@ public class Region_Delegate { // ---- delegate manager ---- protected static final DelegateManager sManager = - new DelegateManager(); + new DelegateManager(Region_Delegate.class); // ---- delegate helper data ---- diff --git a/tools/layoutlib/bridge/src/android/graphics/Shader_Delegate.java b/tools/layoutlib/bridge/src/android/graphics/Shader_Delegate.java index a008d151c6aec..368c0384ded57 100644 --- a/tools/layoutlib/bridge/src/android/graphics/Shader_Delegate.java +++ b/tools/layoutlib/bridge/src/android/graphics/Shader_Delegate.java @@ -40,7 +40,7 @@ public abstract class Shader_Delegate { // ---- delegate manager ---- protected static final DelegateManager sManager = - new DelegateManager(); + new DelegateManager(Shader_Delegate.class); // ---- delegate helper data ---- diff --git a/tools/layoutlib/bridge/src/android/graphics/Typeface_Delegate.java b/tools/layoutlib/bridge/src/android/graphics/Typeface_Delegate.java index 5af16aeb5fb3a..0f084f7d7fc78 100644 --- a/tools/layoutlib/bridge/src/android/graphics/Typeface_Delegate.java +++ b/tools/layoutlib/bridge/src/android/graphics/Typeface_Delegate.java @@ -46,7 +46,7 @@ public final class Typeface_Delegate { // ---- delegate manager ---- private static final DelegateManager sManager = - new DelegateManager(); + new DelegateManager(Typeface_Delegate.class); // ---- delegate helper data ---- private static final String DEFAULT_FAMILY = "sans-serif"; diff --git a/tools/layoutlib/bridge/src/android/graphics/Xfermode_Delegate.java b/tools/layoutlib/bridge/src/android/graphics/Xfermode_Delegate.java index f3401fcadb651..962d69cb6e8d1 100644 --- a/tools/layoutlib/bridge/src/android/graphics/Xfermode_Delegate.java +++ b/tools/layoutlib/bridge/src/android/graphics/Xfermode_Delegate.java @@ -40,7 +40,7 @@ public abstract class Xfermode_Delegate { // ---- delegate manager ---- protected static final DelegateManager sManager = - new DelegateManager(); + new DelegateManager(Xfermode_Delegate.class); // ---- delegate helper data ---- diff --git a/tools/layoutlib/bridge/src/com/android/layoutlib/bridge/impl/DelegateManager.java b/tools/layoutlib/bridge/src/com/android/layoutlib/bridge/impl/DelegateManager.java index 295c98c3eafa9..ae1217d5c5d88 100644 --- a/tools/layoutlib/bridge/src/com/android/layoutlib/bridge/impl/DelegateManager.java +++ b/tools/layoutlib/bridge/src/com/android/layoutlib/bridge/impl/DelegateManager.java @@ -16,6 +16,7 @@ package com.android.layoutlib.bridge.impl; +import com.android.layoutlib.bridge.util.Debug; import com.android.layoutlib.bridge.util.SparseWeakArray; import android.util.SparseArray; @@ -69,6 +70,7 @@ import java.util.List; * @param the delegate class to manage */ public final class DelegateManager { + private final Class mClass; private final SparseWeakArray mDelegates = new SparseWeakArray(); /** list used to store delegates when their main object holds a reference to them. * This is to ensure that the WeakReference in the SparseWeakArray doesn't get GC'ed @@ -78,6 +80,10 @@ public final class DelegateManager { private final List mJavaReferences = new ArrayList(); private int mDelegateCounter = 0; + public DelegateManager(Class theClass) { + mClass = theClass; + } + /** * Returns the delegate from the given native int. *

@@ -91,6 +97,14 @@ public final class DelegateManager { public T getDelegate(int native_object) { if (native_object > 0) { T delegate = mDelegates.get(native_object); + + if (Debug.DEBUG) { + if (delegate == null) { + System.out.println("Unknown " + mClass.getSimpleName() + " with int " + + native_object); + } + } + assert delegate != null; return delegate; } @@ -107,6 +121,11 @@ public final class DelegateManager { mDelegates.put(native_object, newDelegate); assert !mJavaReferences.contains(newDelegate); mJavaReferences.add(newDelegate); + + if (Debug.DEBUG) { + System.out.println("New " + mClass.getSimpleName() + " with int " + native_object); + } + return native_object; } @@ -116,6 +135,12 @@ public final class DelegateManager { */ public void removeJavaReferenceFor(int native_object) { T delegate = getDelegate(native_object); + + if (Debug.DEBUG) { + System.out.println("Removing main Java ref on " + mClass.getSimpleName() + + " with int " + native_object); + } + mJavaReferences.remove(delegate); } } diff --git a/tools/layoutlib/bridge/src/com/android/layoutlib/bridge/util/Debug.java b/tools/layoutlib/bridge/src/com/android/layoutlib/bridge/util/Debug.java new file mode 100644 index 0000000000000..82eab8560acb8 --- /dev/null +++ b/tools/layoutlib/bridge/src/com/android/layoutlib/bridge/util/Debug.java @@ -0,0 +1,23 @@ +/* + * Copyright (C) 2011 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.layoutlib.bridge.util; + +public class Debug { + + public final static boolean DEBUG = false; + +}