From ecd986463db704cc20773eb27d121830976ca7df Mon Sep 17 00:00:00 2001 From: Amin Shaikh Date: Wed, 11 Apr 2018 15:50:57 -0400 Subject: [PATCH 1/2] Fix QQS side padding for icons and tiles. Change-Id: I00b20bd705a1bbe3ee619188cee5e6cbd9f43eed Fixes: 77123524 Test: visual --- packages/SystemUI/res/layout/quick_qs_status_icons.xml | 2 +- packages/SystemUI/res/values-sw372dp/dimens.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/SystemUI/res/layout/quick_qs_status_icons.xml b/packages/SystemUI/res/layout/quick_qs_status_icons.xml index c03f25c751016..04865558d61a9 100644 --- a/packages/SystemUI/res/layout/quick_qs_status_icons.xml +++ b/packages/SystemUI/res/layout/quick_qs_status_icons.xml @@ -21,7 +21,7 @@ android:layout_marginTop="8dp" android:layout_marginBottom="14dp" android:layout_below="@id/quick_status_bar_system_icons" - android:paddingEnd="@dimen/signal_cluster_battery_padding" > + android:paddingEnd="@dimen/qs_header_tile_margin_horizontal" > 8dp 8dp - 5dp + 13dp From 9cac338ac2be569349247247dbc6eca4ecc9fb21 Mon Sep 17 00:00:00 2001 From: Amin Shaikh Date: Wed, 11 Apr 2018 17:10:07 -0400 Subject: [PATCH 2/2] Fix status icon tint in QQS. - Update the right margin for these icons - Update the padding for the status bar and QQS status bar to match. Change-Id: I6358cfe35430d981d813f2cb21a942fa82211d40 Fixes: 77532713 Test: visual --- packages/SystemUI/res/layout/quick_qs_status_icons.xml | 3 ++- .../res/layout/quick_status_bar_header_system_icons.xml | 7 ++++--- packages/SystemUI/res/layout/status_bar.xml | 2 +- packages/SystemUI/res/values/dimens.xml | 3 +++ .../src/com/android/systemui/qs/QuickStatusBarHeader.java | 4 ++-- 5 files changed, 12 insertions(+), 7 deletions(-) diff --git a/packages/SystemUI/res/layout/quick_qs_status_icons.xml b/packages/SystemUI/res/layout/quick_qs_status_icons.xml index 04865558d61a9..dcb8aaf2a6a88 100644 --- a/packages/SystemUI/res/layout/quick_qs_status_icons.xml +++ b/packages/SystemUI/res/layout/quick_qs_status_icons.xml @@ -20,8 +20,9 @@ android:layout_height="20dp" android:layout_marginTop="8dp" android:layout_marginBottom="14dp" + android:layout_marginEnd="@dimen/notification_side_paddings" android:layout_below="@id/quick_status_bar_system_icons" - android:paddingEnd="@dimen/qs_header_tile_margin_horizontal" > + android:paddingEnd="@dimen/status_bar_padding_end" > - 6dp + + 8dp + 1dp diff --git a/packages/SystemUI/src/com/android/systemui/qs/QuickStatusBarHeader.java b/packages/SystemUI/src/com/android/systemui/qs/QuickStatusBarHeader.java index e2af90d6bbce2..216fa78f1370d 100644 --- a/packages/SystemUI/src/com/android/systemui/qs/QuickStatusBarHeader.java +++ b/packages/SystemUI/src/com/android/systemui/qs/QuickStatusBarHeader.java @@ -213,9 +213,9 @@ public class QuickStatusBarHeader extends RelativeLayout implements private int fillColorForIntensity(float intensity, Context context) { if (intensity == 0) { - return context.getColor(R.color.light_mode_icon_color_dual_tone_fill); + return context.getColor(R.color.light_mode_icon_color_single_tone); } - return context.getColor(R.color.dark_mode_icon_color_dual_tone_fill); + return context.getColor(R.color.dark_mode_icon_color_single_tone); } @Override