From ef4782f55d7c00493fe6cd9e10c2a082c2a819e3 Mon Sep 17 00:00:00 2001 From: Jeff DeCew Date: Tue, 31 May 2022 15:59:00 +0000 Subject: [PATCH] Always set the top roundness of child rows to 0. The bug demonstrated that only the top radius was getting into a dirty state. When I saw this function was resetting the bottom roundness and never touching the top roundness, it was clear that we just needed to set the top roundness. Even though it's hard to reproduce the issue where top roundness is incorrectly huge, it's trivial to reproduce the issue where the top roundness is incorrectly small, and this fix definitively addresses that state. Test: post auto-groupable Heads Up notifications. Notice after grouping that child rows now never have any internal corner radii. Fixes: 227433308 Change-Id: I3cd1aa23ad8333f35ec837edd39bc12aeb1573b6 --- .../notification/stack/NotificationChildrenContainer.java | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/NotificationChildrenContainer.java b/packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/NotificationChildrenContainer.java index 34fce4c29c259..c90d2cf6e699f 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/NotificationChildrenContainer.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/NotificationChildrenContainer.java @@ -1299,6 +1299,7 @@ public class NotificationChildrenContainer extends ViewGroup } float bottomRoundness = last ? currentBottomRoundness : 0.0f; child.setBottomRoundness(bottomRoundness, isShown() /* animate */); + child.setTopRoundness(0.0f, false /* animate */); last = false; } }