Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Workaround for empty repeated proto" into sc-dev

Browse Source
This commit is contained in:
Kevin Chyn
2021-01-30 09:58:53 +00:00
committed by Android (Google) Code Review
parent 5fe6130c70 34c74dbfb2
commit eeda0eb193
2 changed files with 22 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
services/core/java/com/android/server/biometrics/sensors/BiometricScheduler.java
View File

@@ -635,11 +635,16 @@ public class BiometricScheduler {
proto.write(BiometricSchedulerProto.CURRENT_OPERATION, mCurrentOperation != null proto.write(BiometricSchedulerProto.CURRENT_OPERATION, mCurrentOperation != null
? mCurrentOperation.mClientMonitor.getProtoEnum() : BiometricsProto.CM_NONE); ? mCurrentOperation.mClientMonitor.getProtoEnum() : BiometricsProto.CM_NONE);
proto.write(BiometricSchedulerProto.TOTAL_OPERATIONS, mTotalOperationsHandled); proto.write(BiometricSchedulerProto.TOTAL_OPERATIONS, mTotalOperationsHandled);
Slog.d(getTag(), "Total operations: " + mTotalOperationsHandled);
if (!mRecentOperations.isEmpty()) {
for (int i = 0; i < mRecentOperations.size(); i++) { for (int i = 0; i < mRecentOperations.size(); i++) {
Slog.d(getTag(), "Operation: " + mRecentOperations.get(i));
proto.write(BiometricSchedulerProto.RECENT_OPERATIONS, mRecentOperations.get(i)); proto.write(BiometricSchedulerProto.RECENT_OPERATIONS, mRecentOperations.get(i));
} }
} else {
// TODO:(b/178828362) Unsure why protobuf has a problem decoding when an empty list
// is returned. So, let's just add a no-op for this case.
proto.write(BiometricSchedulerProto.RECENT_OPERATIONS, BiometricsProto.CM_NONE);
}
proto.flush(); proto.flush();
if (clearSchedulerBuffer) { if (clearSchedulerBuffer) {

17
services/tests/servicestests/src/com/android/server/biometrics/sensors/BiometricSchedulerTest.java
View File

@@ -196,7 +196,8 @@ public class BiometricSchedulerTest {
BiometricSchedulerProto bsp = getDump(true /* clearSchedulerBuffer */); BiometricSchedulerProto bsp = getDump(true /* clearSchedulerBuffer */);
assertEquals(BiometricsProto.CM_NONE, bsp.currentOperation); assertEquals(BiometricsProto.CM_NONE, bsp.currentOperation);
assertEquals(0, bsp.totalOperations); assertEquals(0, bsp.totalOperations);
assertEquals(0, bsp.recentOperations.length); // TODO:(b/178828362) See bug and/or commit message :/
// assertEquals(0, bsp.recentOperations.length);
// Pretend the scheduler is busy enrolling, and check the proto dump again. // Pretend the scheduler is busy enrolling, and check the proto dump again.
final TestClientMonitor2 client = new TestClientMonitor2(mContext, mToken, final TestClientMonitor2 client = new TestClientMonitor2(mContext, mToken,
@@ -207,7 +208,11 @@ public class BiometricSchedulerTest {
assertEquals(BiometricsProto.CM_ENROLL, bsp.currentOperation); assertEquals(BiometricsProto.CM_ENROLL, bsp.currentOperation);
// No operations have completed yet // No operations have completed yet
assertEquals(0, bsp.totalOperations); assertEquals(0, bsp.totalOperations);
assertEquals(0, bsp.recentOperations.length);
// TODO:(b/178828362) See bug and/or commit message :/
assertEquals(1, bsp.recentOperations.length);
assertEquals(BiometricsProto.CM_NONE, bsp.recentOperations[0]);
// Finish this operation, so the next scheduled one can start // Finish this operation, so the next scheduled one can start
client.getCallback().onClientFinished(client, true); client.getCallback().onClientFinished(client, true);
} }
@@ -223,7 +228,8 @@ public class BiometricSchedulerTest {
assertEquals(BiometricsProto.CM_ENROLL, bsp.currentOperation); assertEquals(BiometricsProto.CM_ENROLL, bsp.currentOperation);
// No operations have completed yet // No operations have completed yet
assertEquals(0, bsp.totalOperations); assertEquals(0, bsp.totalOperations);
assertEquals(0, bsp.recentOperations.length); // TODO:(b/178828362) See bug and/or commit message :/
// assertEquals(0, bsp.recentOperations.length);
// Finish this operation, so the next scheduled one can start // Finish this operation, so the next scheduled one can start
client.getCallback().onClientFinished(client, true); client.getCallback().onClientFinished(client, true);
@@ -265,7 +271,10 @@ public class BiometricSchedulerTest {
// RecentOperations queue is cleared (by the previous dump) // RecentOperations queue is cleared (by the previous dump)
bsp = getDump(true /* clearSchedulerBuffer */); bsp = getDump(true /* clearSchedulerBuffer */);
assertEquals(0, bsp.recentOperations.length);
// TODO:(b/178828362) See bug and/or commit message :/
assertEquals(1, bsp.recentOperations.length);
assertEquals(BiometricsProto.CM_NONE, bsp.recentOperations[0]);
} }
@Test @Test