From 328a29cc486fac849fa4dd01c9a35d4703f085ff Mon Sep 17 00:00:00 2001 From: Stephen Hines Date: Tue, 9 Jun 2020 00:14:52 -0700 Subject: [PATCH] Add back missing `tidy_checks`, since `tidy_checks_as_errors` isn't enough I unfortunately missed in the original testing that `tidy_checks_as_errors` isn't sufficient by itself. Instead we need to have both places with the same variables. A future change will make Soong expand `tidy_checks_as_errors` into both locations appropriately. Bug: 119328308 Test: WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=*,-readability-*,-google-readability-*,-google-runtime-references,-cppcoreguidelines-*,-modernize-*,-llvm-*,-bugprone-narrowing-conversions,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-hicpp-*,-fuchsia-* mm Change-Id: If69f69bf7861ba3569756270381f3f737366f2f0 Merged-In: If69f69bf7861ba3569756270381f3f737366f2f0 (cherry picked from commit 56af59395e0cdcebeb9b01813f752cc22468c4c0) --- cmds/idmap2/Android.bp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/cmds/idmap2/Android.bp b/cmds/idmap2/Android.bp index 771c0ef5260ac..4e57e884ee3e4 100644 --- a/cmds/idmap2/Android.bp +++ b/cmds/idmap2/Android.bp @@ -15,6 +15,14 @@ cc_defaults { name: "idmap2_defaults", tidy: true, + tidy_checks: [ + "modernize-*", + "-modernize-avoid-c-arrays", + "-modernize-use-trailing-return-type", + "android-*", + "misc-*", + "readability-*", + ], tidy_checks_as_errors: [ "modernize-*", "-modernize-avoid-c-arrays",