From ee0e486d3617bdc31ae6e42414bbf2316dee164c Mon Sep 17 00:00:00 2001 From: Adam Lesinski Date: Tue, 25 Jul 2017 17:15:42 -0700 Subject: [PATCH] AAPT2: Add navigation type Test: build succeeds Bug: 65645766 Change-Id: I7d49366c7cc4a93c29bad4cb9f13eec23ad05bd2 Merged-In: I7d49366c7cc4a93c29bad4cb9f13eec23ad05bd2 --- tools/aapt2/Resource.cpp | 3 +++ tools/aapt2/Resource.h | 1 + tools/aapt2/Resource_test.cpp | 4 ++++ tools/aapt2/integration-tests/AppOne/res/navigation/home.xml | 2 ++ tools/aapt2/readme.md | 3 +++ 5 files changed, 13 insertions(+) create mode 100644 tools/aapt2/integration-tests/AppOne/res/navigation/home.xml diff --git a/tools/aapt2/Resource.cpp b/tools/aapt2/Resource.cpp index 35971e7bd99b6..a9f5f298e019f 100644 --- a/tools/aapt2/Resource.cpp +++ b/tools/aapt2/Resource.cpp @@ -61,6 +61,8 @@ StringPiece ToString(ResourceType type) { return "menu"; case ResourceType::kMipmap: return "mipmap"; + case ResourceType::kNavigation: + return "navigation"; case ResourceType::kPlurals: return "plurals"; case ResourceType::kRaw: @@ -98,6 +100,7 @@ static const std::map sResourceTypeMap{ {"layout", ResourceType::kLayout}, {"menu", ResourceType::kMenu}, {"mipmap", ResourceType::kMipmap}, + {"navigation", ResourceType::kNavigation}, {"plurals", ResourceType::kPlurals}, {"raw", ResourceType::kRaw}, {"string", ResourceType::kString}, diff --git a/tools/aapt2/Resource.h b/tools/aapt2/Resource.h index 0a74c1a0f77df..cbcc8fb805aa1 100644 --- a/tools/aapt2/Resource.h +++ b/tools/aapt2/Resource.h @@ -59,6 +59,7 @@ enum class ResourceType { kLayout, kMenu, kMipmap, + kNavigation, kPlurals, kRaw, kString, diff --git a/tools/aapt2/Resource_test.cpp b/tools/aapt2/Resource_test.cpp index ad4e3ce02b32b..c557f3c776544 100644 --- a/tools/aapt2/Resource_test.cpp +++ b/tools/aapt2/Resource_test.cpp @@ -93,6 +93,10 @@ TEST(ResourceTypeTest, ParseResourceTypes) { ASSERT_NE(type, nullptr); EXPECT_EQ(*type, ResourceType::kMipmap); + type = ParseResourceType("navigation"); + ASSERT_NE(type, nullptr); + EXPECT_EQ(*type, ResourceType::kNavigation); + type = ParseResourceType("plurals"); ASSERT_NE(type, nullptr); EXPECT_EQ(*type, ResourceType::kPlurals); diff --git a/tools/aapt2/integration-tests/AppOne/res/navigation/home.xml b/tools/aapt2/integration-tests/AppOne/res/navigation/home.xml new file mode 100644 index 0000000000000..ade271d60ab6f --- /dev/null +++ b/tools/aapt2/integration-tests/AppOne/res/navigation/home.xml @@ -0,0 +1,2 @@ + + diff --git a/tools/aapt2/readme.md b/tools/aapt2/readme.md index c8d36177beb47..2645d54867de4 100644 --- a/tools/aapt2/readme.md +++ b/tools/aapt2/readme.md @@ -1,5 +1,8 @@ # Android Asset Packaging Tool 2.0 (AAPT2) release notes +## Version 2.19 +- Added navigation resource type. + ## Version 2.18 ### `aapt2 ...` - Fixed issue where enum values were interpreted as integers and range checked. (bug 62358540)