diff --git a/config/hiddenapi-max-target-o.txt b/config/hiddenapi-max-target-o.txt index 592b4aedf9521..3fee56863cf59 100644 --- a/config/hiddenapi-max-target-o.txt +++ b/config/hiddenapi-max-target-o.txt @@ -91672,7 +91672,6 @@ Lcom/android/internal/R$dimen;->notification_media_image_max_height_low_ram:I Lcom/android/internal/R$dimen;->notification_media_image_max_width:I Lcom/android/internal/R$dimen;->notification_media_image_max_width_low_ram:I Lcom/android/internal/R$dimen;->notification_messaging_spacing:I -Lcom/android/internal/R$dimen;->notification_min_content_height:I Lcom/android/internal/R$dimen;->notification_reply_inset:I Lcom/android/internal/R$dimen;->notification_right_icon_size:I Lcom/android/internal/R$dimen;->notification_right_icon_size_low_ram:I diff --git a/core/java/android/app/Notification.java b/core/java/android/app/Notification.java index 70b7d22d51e67..75f7ceca64500 100644 --- a/core/java/android/app/Notification.java +++ b/core/java/android/app/Notification.java @@ -4922,8 +4922,6 @@ public class Notification implements Parcelable contentView.setViewVisibility(textId, View.VISIBLE); } - setContentMinHeight(contentView, showProgress || mN.hasLargeIcon()); - return contentView; } @@ -5081,21 +5079,6 @@ public class Notification implements Parcelable } } - /** - * @param remoteView the remote view to update the minheight in - * @param hasMinHeight does it have a mimHeight - * @hide - */ - void setContentMinHeight(RemoteViews remoteView, boolean hasMinHeight) { - int minHeight = 0; - if (hasMinHeight) { - // we need to set the minHeight of the notification - minHeight = mContext.getResources().getDimensionPixelSize( - com.android.internal.R.dimen.notification_min_content_height); - } - remoteView.setInt(R.id.notification_main_column, "setMinimumHeight", minHeight); - } - private boolean handleProgressBar(RemoteViews contentView, Bundle ex, StandardTemplateParams p) { final int max = ex.getInt(EXTRA_PROGRESS_MAX, 0); @@ -6942,7 +6925,6 @@ public class Notification implements Parcelable mBuilder.setTextViewColorSecondary(contentView, R.id.text, p); contentView.setViewVisibility(R.id.text, View.VISIBLE); } - mBuilder.setContentMinHeight(contentView, mBuilder.mN.hasLargeIcon()); if (mBigLargeIconSet) { mBuilder.mN.mLargeIcon = oldLargeIcon; @@ -8710,7 +8692,7 @@ public class Notification implements Parcelable RemoteViews remoteViews = mBuilder.applyStandardTemplateWithActions( mBuilder.getHeadsUpBaseLayoutResource(), StandardTemplateParams.VIEW_TYPE_HEADS_UP, result); - buildIntoRemoteViewContent(remoteViews, headsUpContentView, result, false); + buildIntoRemoteViewContent(remoteViews, headsUpContentView, result, true); return remoteViews; } @@ -8755,8 +8737,7 @@ public class Notification implements Parcelable Resources resources = mBuilder.mContext.getResources(); int endMargin = resources.getDimensionPixelSize( R.dimen.notification_content_margin_end) + result.getTitleMarginEnd(); - remoteViews.setViewLayoutMarginEnd(R.id.notification_main_column, - endMargin); + remoteViews.setViewLayoutMarginEnd(R.id.notification_main_column, endMargin); } } diff --git a/core/res/res/layout/notification_template_material_base.xml b/core/res/res/layout/notification_template_material_base.xml index 46b3a8f4644fb..ded16b7edf87b 100644 --- a/core/res/res/layout/notification_template_material_base.xml +++ b/core/res/res/layout/notification_template_material_base.xml @@ -33,16 +33,30 @@ android:padding="@dimen/notification_icon_circle_padding" /> - + + + - - - + + + + + + diff --git a/core/res/res/layout/notification_template_material_big_text.xml b/core/res/res/layout/notification_template_material_big_text.xml index b8e827d7d10f8..2452a32b21eb4 100644 --- a/core/res/res/layout/notification_template_material_big_text.xml +++ b/core/res/res/layout/notification_template_material_big_text.xml @@ -48,7 +48,6 @@ android:paddingStart="@dimen/notification_content_margin_start" android:paddingEnd="@dimen/notification_content_margin_end" android:clipToPadding="false" - android:minHeight="@dimen/notification_min_content_height" android:orientation="vertical" android:layout_weight="1" > diff --git a/core/res/res/layout/notification_template_material_inbox.xml b/core/res/res/layout/notification_template_material_inbox.xml index eb8925819cd32..e6fa50336e00c 100644 --- a/core/res/res/layout/notification_template_material_inbox.xml +++ b/core/res/res/layout/notification_template_material_inbox.xml @@ -39,7 +39,6 @@ android:layout_gravity="top" android:paddingStart="@dimen/notification_content_margin_start" android:paddingEnd="@dimen/notification_content_margin_end" - android:minHeight="@dimen/notification_min_content_height" android:layout_weight="1" android:clipToPadding="false" android:orientation="vertical" diff --git a/core/res/res/layout/notification_template_material_media.xml b/core/res/res/layout/notification_template_material_media.xml index 575295b1be459..52053dcdf8004 100644 --- a/core/res/res/layout/notification_template_material_media.xml +++ b/core/res/res/layout/notification_template_material_media.xml @@ -55,7 +55,6 @@ android:layout_height="wrap_content" android:layout_gravity="fill_vertical" android:layout_weight="1" - android:minHeight="@dimen/notification_min_content_height" android:paddingBottom="@dimen/notification_content_margin" android:orientation="vertical" > diff --git a/core/res/res/layout/notification_template_material_messaging.xml b/core/res/res/layout/notification_template_material_messaging.xml index de9814b9f1f12..c3fd249d3ad57 100644 --- a/core/res/res/layout/notification_template_material_messaging.xml +++ b/core/res/res/layout/notification_template_material_messaging.xml @@ -40,7 +40,6 @@ android:layout_weight="1" android:layout_marginStart="@dimen/notification_content_margin_start" android:layout_marginEnd="@dimen/notification_content_margin_end" - android:minHeight="@dimen/notification_min_content_height" android:orientation="vertical" > 1dp - - 18dp + + 8dp + + + 10dp 20sp @@ -319,9 +322,6 @@ 72dp - - 39dp - 48dp diff --git a/core/res/res/values/symbols.xml b/core/res/res/values/symbols.xml index 7567468165760..23733af4455ea 100644 --- a/core/res/res/values/symbols.xml +++ b/core/res/res/values/symbols.xml @@ -2871,7 +2871,6 @@ -