From ede3a17f6079b7da62240bbcaf613591ba2fc055 Mon Sep 17 00:00:00 2001
From: Roozbeh Pournader <roozbeh@google.com>
Date: Wed, 27 Jul 2016 16:35:12 -0700
Subject: [PATCH] Add test for ascent and descent of serif and mono fonts

fontchain_lint now has tests making sure that their ascent and
descent matches that of Roboto.

Also, this moves a test class that contains a similar test and and
other related tests from graphictests to coretests.

Bug: 19791102
Change-Id: I8b473dd2a5f97ae2e3d322a2cabc16f3d32489f6
---
 .../coretests}/src/android/graphics/TypefaceTest.java  |  1 +
 .../src/android/graphics/GraphicsTests.java            |  1 -
 tools/fonts/fontchain_lint.py                          | 10 +++++++---
 3 files changed, 8 insertions(+), 4 deletions(-)
 rename {graphics/tests/graphicstests => core/tests/coretests}/src/android/graphics/TypefaceTest.java (99%)

diff --git a/graphics/tests/graphicstests/src/android/graphics/TypefaceTest.java b/core/tests/coretests/src/android/graphics/TypefaceTest.java
similarity index 99%
rename from graphics/tests/graphicstests/src/android/graphics/TypefaceTest.java
rename to core/tests/coretests/src/android/graphics/TypefaceTest.java
index 334fddf78fbf4..c8ce884cf8267 100644
--- a/graphics/tests/graphicstests/src/android/graphics/TypefaceTest.java
+++ b/core/tests/coretests/src/android/graphics/TypefaceTest.java
@@ -20,6 +20,7 @@ import android.graphics.Paint;
 import android.graphics.Typeface;
 import android.test.suitebuilder.annotation.MediumTest;
 import android.test.suitebuilder.annotation.SmallTest;
+
 import junit.framework.TestCase;
 
 
diff --git a/graphics/tests/graphicstests/src/android/graphics/GraphicsTests.java b/graphics/tests/graphicstests/src/android/graphics/GraphicsTests.java
index 8d01ea7ffd419..70f5976843bc7 100644
--- a/graphics/tests/graphicstests/src/android/graphics/GraphicsTests.java
+++ b/graphics/tests/graphicstests/src/android/graphics/GraphicsTests.java
@@ -23,7 +23,6 @@ public class GraphicsTests {
         TestSuite suite = new TestSuite(GraphicsTests.class.getName());
 
         suite.addTestSuite(BitmapTest.class);
-        suite.addTestSuite(TypefaceTest.class);
         return suite;
     }
 }
diff --git a/tools/fonts/fontchain_lint.py b/tools/fonts/fontchain_lint.py
index b6f46a2423aee..072a4a756d24c 100755
--- a/tools/fonts/fontchain_lint.py
+++ b/tools/fonts/fontchain_lint.py
@@ -558,9 +558,13 @@ def check_vertical_metrics():
     for record in _fallback_chain:
         if record.name in ['sans-serif', 'sans-serif-condensed']:
             font = open_font(record.font)
-            assert (font['head'].yMax == 2163 and font['head'].yMin == -555 and
-                    font['hhea'].ascent == 1900 and font['hhea'].descent == -500), (
-                   'Vertical metrics of %s do not match expected Roboto metrics.' % (record.font,))
+            assert font['head'].yMax == 2163 and font['head'].yMin == -555, (
+                'yMax and yMin of %s do not match expected values.' % (record.font,))
+
+        if record.name in ['sans-serif', 'sans-serif-condensed', 'serif', 'monospace']:
+            font = open_font(record.font)
+            assert font['hhea'].ascent == 1900 and font['hhea'].descent == -500, (
+                'ascent and descent of %s do not match expected values.' % (record.font,))
 
 
 def main():