From dd082b65effeb3a4bb0052ac3851b1b161260a3b Mon Sep 17 00:00:00 2001 From: Joshua Tsuji Date: Wed, 20 May 2020 22:26:24 -0400 Subject: [PATCH] Tint the pointer white at all times. Currently Bubble backgrounds are also white at all times (we think for background protection reasons?), so it makes sense to align these. If we reopen b/153367093 with a fix that allows for dark-backgrounded bubbles in dark mode, I'll apply the same fix here. Test: manual Fixes: 130834403 Change-Id: I92a81b8c224cbb2ac580bdfc4e40bdd2744d353e --- .../com/android/systemui/bubbles/BubbleExpandedView.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/bubbles/BubbleExpandedView.java b/packages/SystemUI/src/com/android/systemui/bubbles/BubbleExpandedView.java index baf92dc7abe7c..769740032509e 100644 --- a/packages/SystemUI/src/com/android/systemui/bubbles/BubbleExpandedView.java +++ b/packages/SystemUI/src/com/android/systemui/bubbles/BubbleExpandedView.java @@ -250,6 +250,7 @@ public class BubbleExpandedView extends LinearLayout { mPointerDrawable = new ShapeDrawable(TriangleShape.create( mPointerWidth, mPointerHeight, true /* pointUp */)); + mPointerDrawable.setTint(Color.WHITE); mPointerView.setBackground(mPointerDrawable); mPointerView.setVisibility(INVISIBLE); @@ -311,14 +312,10 @@ public class BubbleExpandedView extends LinearLayout { void applyThemeAttrs() { final TypedArray ta = mContext.obtainStyledAttributes( - new int[] { - android.R.attr.colorBackgroundFloating, - android.R.attr.dialogCornerRadius}); - int bgColor = ta.getColor(0, Color.WHITE); - float cornerRadius = ta.getDimensionPixelSize(1, 0); + new int[] {android.R.attr.dialogCornerRadius}); + float cornerRadius = ta.getDimensionPixelSize(0, 0); ta.recycle(); - mPointerDrawable.setTint(bgColor); if (mActivityView != null && ScreenDecorationsUtils.supportsRoundedCornersOnWindows( mContext.getResources())) { mActivityView.setCornerRadius(cornerRadius);