Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Frameworks/base: Use holder in FileUtils" into nyc-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2016-04-29 07:09:27 +00:00
committed by Android (Google) Code Review
parent cbb128a5d8 0693fd85f6
commit ecd73f48fe
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
core/java/android/os/FileUtils.java
View File

@@ -72,8 +72,13 @@ public class FileUtils {
public static final int S_IWOTH = 00002; public static final int S_IWOTH = 00002;
public static final int S_IXOTH = 00001; public static final int S_IXOTH = 00001;
/** Regular expression for safe filenames: no spaces or metacharacters */ /** Regular expression for safe filenames: no spaces or metacharacters.
private static final Pattern SAFE_FILENAME_PATTERN = Pattern.compile("[\\w%+,./=_-]+"); *
* Use a preload holder so that FileUtils can be compile-time initialized.
*/
private static class NoImagePreloadHolder {
public static final Pattern SAFE_FILENAME_PATTERN = Pattern.compile("[\\w%+,./=_-]+");
}
private static final File[] EMPTY = new File[0]; private static final File[] EMPTY = new File[0];
@@ -243,7 +248,7 @@ public class FileUtils {
// Note, we check whether it matches what's known to be safe, // Note, we check whether it matches what's known to be safe,
// rather than what's known to be unsafe. Non-ASCII, control // rather than what's known to be unsafe. Non-ASCII, control
// characters, etc. are all unsafe by default. // characters, etc. are all unsafe by default.
return SAFE_FILENAME_PATTERN.matcher(file.getPath()).matches(); return NoImagePreloadHolder.SAFE_FILENAME_PATTERN.matcher(file.getPath()).matches();
} }
/** /**