From ec44c26f42c828ce98117d280c7bd4e54bde39b1 Mon Sep 17 00:00:00 2001 From: Robert Greenwalt Date: Thu, 11 Nov 2010 15:18:51 -0800 Subject: [PATCH] Make getDataEnabled take more into account. getDataEnabled and getAnyDataEnabled ignored mMasterDataEnabled. bug: 2216392 Change-Id: Ic3ae0808d2a02057ddf5056d3e01f754f2e57f5c --- .../internal/telephony/DataConnectionTracker.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/telephony/java/com/android/internal/telephony/DataConnectionTracker.java b/telephony/java/com/android/internal/telephony/DataConnectionTracker.java index 2a21f6d93399e..96c90a2dbb425 100644 --- a/telephony/java/com/android/internal/telephony/DataConnectionTracker.java +++ b/telephony/java/com/android/internal/telephony/DataConnectionTracker.java @@ -478,7 +478,7 @@ public abstract class DataConnectionTracker extends Handler { * {@code true} otherwise. */ public synchronized boolean getDataEnabled() { - return dataEnabled[APN_DEFAULT_ID]; + return (mMasterDataEnabled && dataEnabled[APN_DEFAULT_ID]); } /** @@ -487,8 +487,8 @@ public abstract class DataConnectionTracker extends Handler { * @return {@code false} if data connectivity has been explicitly disabled, * {@code true} otherwise. */ - public boolean getAnyDataEnabled() { - return (enabledCount != 0); + public synchronized boolean getAnyDataEnabled() { + return (mMasterDataEnabled && (enabledCount != 0)); } protected abstract void startNetStatPoll(); @@ -832,7 +832,9 @@ public abstract class DataConnectionTracker extends Handler { protected void onSetDataEnabled(boolean enable) { if (mMasterDataEnabled != enable) { - mMasterDataEnabled = enable; + synchronized (this) { + mMasterDataEnabled = enable; + } if (enable) { mRetryMgr.resetRetryCount(); onTrySetupData(Phone.REASON_DATA_ENABLED);