From d3f42c6e905d9352e20bf5112ddc015e0aa57153 Mon Sep 17 00:00:00 2001 From: Shawn Lee Date: Tue, 4 Oct 2022 14:30:24 -0700 Subject: [PATCH] Removed some container views from TalkBack/SwitchAccess Some container views in shade were not marked as not important for accessibility, so SwitchAccess was announcing them as "Unknown Item". Removed them here instead of adding labels as selecting on them did no meaningful action/did a redundant action. Test: manually tried to select the views using SwitchAccess Bug: 200246909 Change-Id: I6a5061703c6082fca596c4dd055b1d4f86579bcb --- .../SystemUI/res/layout/quick_status_bar_expanded_header.xml | 3 ++- .../res/layout/quick_status_bar_header_date_privacy.xml | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/SystemUI/res/layout/quick_status_bar_expanded_header.xml b/packages/SystemUI/res/layout/quick_status_bar_expanded_header.xml index 2fb6d6cb9bd54..9fc3f409642b0 100644 --- a/packages/SystemUI/res/layout/quick_status_bar_expanded_header.xml +++ b/packages/SystemUI/res/layout/quick_status_bar_expanded_header.xml @@ -23,6 +23,7 @@ android:layout_height="wrap_content" android:layout_gravity="@integer/notification_panel_layout_gravity" android:background="@android:color/transparent" + android:importantForAccessibility="no" android:baselineAligned="false" android:clickable="false" android:clipChildren="false" @@ -56,7 +57,7 @@ android:clipToPadding="false" android:focusable="true" android:paddingBottom="@dimen/qqs_layout_padding_bottom" - android:importantForAccessibility="yes"> + android:importantForAccessibility="no"> diff --git a/packages/SystemUI/res/layout/quick_status_bar_header_date_privacy.xml b/packages/SystemUI/res/layout/quick_status_bar_header_date_privacy.xml index 60bc3732cde05..8b5d953c3fe71 100644 --- a/packages/SystemUI/res/layout/quick_status_bar_header_date_privacy.xml +++ b/packages/SystemUI/res/layout/quick_status_bar_header_date_privacy.xml @@ -25,6 +25,7 @@ android:gravity="center" android:layout_gravity="top" android:orientation="horizontal" + android:importantForAccessibility="no" android:clickable="true" android:minHeight="48dp">