Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Set idmap2 binary uid and gid after forking" into qt-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2019-07-02 17:07:32 +00:00
committed by Android (Google) Code Review
parent ac1c8ddcc3 a8f13667c2
commit ebad9125c8
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
libs/androidfw/PosixUtils.cpp
View File

@@ -64,6 +64,9 @@ std::unique_ptr<ProcResult> ExecuteBinary(const std::vector<std::string>& argv)
return nullptr; return nullptr;
} }
auto gid = getgid();
auto uid = getuid();
char const** argv0 = (char const**)malloc(sizeof(char*) * (argv.size() + 1)); char const** argv0 = (char const**)malloc(sizeof(char*) * (argv.size() + 1));
for (size_t i = 0; i < argv.size(); i++) { for (size_t i = 0; i < argv.size(); i++) {
argv0[i] = argv[i].c_str(); argv0[i] = argv[i].c_str();
@@ -75,6 +78,16 @@ std::unique_ptr<ProcResult> ExecuteBinary(const std::vector<std::string>& argv)
PLOG(ERROR) << "fork"; PLOG(ERROR) << "fork";
return nullptr; return nullptr;
case 0: // child case 0: // child
if (setgid(gid) != 0) {
PLOG(ERROR) << "setgid";
exit(1);
}
if (setuid(uid) != 0) {
PLOG(ERROR) << "setuid";
exit(1);
}
close(stdout[0]); close(stdout[0]);
if (dup2(stdout[1], STDOUT_FILENO) == -1) { if (dup2(stdout[1], STDOUT_FILENO) == -1) {
abort(); abort();