diff --git a/packages/SettingsLib/src/com/android/settingslib/Utils.java b/packages/SettingsLib/src/com/android/settingslib/Utils.java index c756fdb9909ee..e49546f5a66f8 100644 --- a/packages/SettingsLib/src/com/android/settingslib/Utils.java +++ b/packages/SettingsLib/src/com/android/settingslib/Utils.java @@ -26,7 +26,7 @@ import android.provider.Settings; import com.android.internal.annotations.VisibleForTesting; import com.android.internal.util.UserIcons; import com.android.settingslib.drawable.UserIconDrawable; -import com.android.settingslib.wrapper.LocationManagerWrapper; + import java.text.NumberFormat; public class Utils { @@ -68,8 +68,7 @@ public class Utils { intent, UserHandle.of(userId), android.Manifest.permission.WRITE_SECURE_SETTINGS); LocationManager locationManager = (LocationManager) context.getSystemService(Context.LOCATION_SERVICE); - LocationManagerWrapper wrapper = new LocationManagerWrapper(locationManager); - wrapper.setLocationEnabledForUser(enabled, UserHandle.of(userId)); + locationManager.setLocationEnabledForUser(enabled, UserHandle.of(userId)); } public static boolean updateLocationMode(Context context, int oldMode, int newMode, int userId, diff --git a/packages/SettingsLib/src/com/android/settingslib/wrapper/LocationManagerWrapper.java b/packages/SettingsLib/src/com/android/settingslib/wrapper/LocationManagerWrapper.java deleted file mode 100644 index 1a268a608e5dc..0000000000000 --- a/packages/SettingsLib/src/com/android/settingslib/wrapper/LocationManagerWrapper.java +++ /dev/null @@ -1,64 +0,0 @@ -/* - * Copyright (C) 2017 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package com.android.settingslib.wrapper; - -import android.location.LocationManager; -import android.os.UserHandle; - -/** - * This class replicates some methods of android.location.LocationManager that are new and not - * yet available in our current version of Robolectric. It provides a thin wrapper to call the real - * methods in production and a mock in tests. - */ -public class LocationManagerWrapper { - - private LocationManager mLocationManager; - - public LocationManagerWrapper(LocationManager locationManager) { - mLocationManager = locationManager; - } - - /** Returns the real {@code LocationManager} object */ - public LocationManager getLocationManager() { - return mLocationManager; - } - - /** Wraps {@code LocationManager.isProviderEnabled} method */ - public boolean isProviderEnabled(String provider) { - return mLocationManager.isProviderEnabled(provider); - } - - /** Wraps {@code LocationManager.setProviderEnabledForUser} method */ - public void setProviderEnabledForUser(String provider, boolean enabled, UserHandle userHandle) { - mLocationManager.setProviderEnabledForUser(provider, enabled, userHandle); - } - - /** Wraps {@code LocationManager.isLocationEnabled} method */ - public boolean isLocationEnabled() { - return mLocationManager.isLocationEnabled(); - } - - /** Wraps {@code LocationManager.isLocationEnabledForUser} method */ - public boolean isLocationEnabledForUser(UserHandle userHandle) { - return mLocationManager.isLocationEnabledForUser(userHandle); - } - - /** Wraps {@code LocationManager.setLocationEnabledForUser} method */ - public void setLocationEnabledForUser(boolean enabled, UserHandle userHandle) { - mLocationManager.setLocationEnabledForUser(enabled, userHandle); - } -} diff --git a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/UtilsTest.java b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/UtilsTest.java index 706d0c0f51e5f..06e31aa315e03 100644 --- a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/UtilsTest.java +++ b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/UtilsTest.java @@ -39,8 +39,6 @@ import android.provider.Settings; import android.provider.Settings.Secure; import android.text.TextUtils; -import com.android.settingslib.wrapper.LocationManagerWrapper; - import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -60,7 +58,7 @@ import java.util.Map; @RunWith(SettingsLibRobolectricTestRunner.class) @Config(shadows = { UtilsTest.ShadowSecure.class, - UtilsTest.ShadowLocationManagerWrapper.class}) + UtilsTest.ShadowLocationManager.class}) public class UtilsTest { private static final double[] TEST_PERCENTAGES = {0, 0.4, 0.5, 0.6, 49, 49.3, 49.8, 50, 100}; private static final String PERCENTAGE_0 = "0%"; @@ -187,8 +185,8 @@ public class UtilsTest { } } - @Implements(value = LocationManagerWrapper.class) - public static class ShadowLocationManagerWrapper { + @Implements(value = LocationManager.class) + public static class ShadowLocationManager { @Implementation public void setLocationEnabledForUser(boolean enabled, UserHandle userHandle) {