From 5ae0b7abf0d026973d556a8d6685dc2b986bf7b5 Mon Sep 17 00:00:00 2001 From: George Mount Date: Tue, 31 May 2016 12:58:52 -0700 Subject: [PATCH] Better handling of confused finish transition. Bug 28347277 When an activity calls startActivity with makeSceneTransitionAnimation and then calls finishAfterTransition, it should not do any transition and just finish. Change-Id: I00e537638fa6f24c95605f09bbafd843b569bb4d --- core/java/android/app/ActivityTransitionState.java | 2 +- core/java/android/app/EnterTransitionCoordinator.java | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/core/java/android/app/ActivityTransitionState.java b/core/java/android/app/ActivityTransitionState.java index 4a1aff74ddf64..02eb4d3ded1c1 100644 --- a/core/java/android/app/ActivityTransitionState.java +++ b/core/java/android/app/ActivityTransitionState.java @@ -284,7 +284,7 @@ class ActivityTransitionState { } public boolean startExitBackTransition(final Activity activity) { - if (mEnteringNames == null) { + if (mEnteringNames == null || mCalledExitCoordinator != null) { return false; } else { if (!mHasExited) { diff --git a/core/java/android/app/EnterTransitionCoordinator.java b/core/java/android/app/EnterTransitionCoordinator.java index a5995846014e5..8bf1e9a97e484 100644 --- a/core/java/android/app/EnterTransitionCoordinator.java +++ b/core/java/android/app/EnterTransitionCoordinator.java @@ -150,6 +150,7 @@ class EnterTransitionCoordinator extends ActivityTransitionCoordinator { } }; decor.getViewTreeObserver().addOnPreDrawListener(mViewsReadyListener); + decor.invalidate(); } }